refactor!: Rename NewPullRequest to CreatePullRequest and pass it by value (#4395)

BREAKING CHANGE: `NewPullRequest` is renamed to `CreatePullRequest`, `PullRequests.Create` now takes it by value, and `CreatePullRequest.Head` and `CreatePullRequest.Base` are now `string`.

Author: JamBalaya56562

.golangci.yml

@@ -238,7 +238,6 @@ linters:
             - LockIssueOptions
             - MaintenanceOptions
             - Milestone
-            - NewPullRequest
             - Organization
             - PagesUpdate
             - PagesUpdateWithoutCNAME

example/commitpr/main.go

@@ -194,11 +194,11 @@ func createPR() (err error) {
 		prRepo = sourceRepo
 	}
 
-	newPR := &github.NewPullRequest{
+	newPR := github.CreatePullRequest{
 		Title:               prSubject,
-		Head:                commitBranch,
+		Head:                *commitBranch,
 		HeadRepo:            repoBranch,
-		Base:                prBranch,
+		Base:                *prBranch,
 		Body:                prDescription,
 		MaintainerCanModify: github.Ptr(true),
 	}

github/examples_test.go

@@ -135,10 +135,10 @@ func ExamplePullRequestsService_Create() {
 		log.Fatalf("Error creating GitHub client: %v", err)
 	}
 
-	newPR := &github.NewPullRequest{
+	newPR := github.CreatePullRequest{
 		Title:               github.Ptr("My awesome pull request"),
-		Head:                github.Ptr("branch_to_merge"),
-		Base:                github.Ptr("master"),
+		Head:                "branch_to_merge",
+		Base:                "master",
 		Body:                github.Ptr("This is the description of the PR created with the package `github.com/google/go-github/github`"),
 		MaintainerCanModify: github.Ptr(true),
 	}

github/github-accessors.go

@@ -258,19 +258,19 @@ func (s *PullRequestsService) GetRaw(ctx context.Context, owner, repo string, nu
 	return buf.String(), resp, nil
 }
 
-// NewPullRequest represents a new pull request to be created.
-type NewPullRequest struct {
+// CreatePullRequest represents a request to create a pull request.
+type CreatePullRequest struct {
 	Title *string `json:"title,omitempty"`
 	// The name of the branch where your changes are implemented. For
 	// cross-repository pull requests in the same network, namespace head with
 	// a user like this: username:branch.
-	Head     *string `json:"head,omitempty"`
+	Head     string  `json:"head"`
 	HeadRepo *string `json:"head_repo,omitempty"`
 	// The name of the branch you want the changes pulled into. This should be
 	// an existing branch on the current repository. You cannot submit a pull
 	// request to one repository that requests a merge to a base of another
 	// repository.
-	Base                *string `json:"base,omitempty"`
+	Base                string  `json:"base"`
 	Body                *string `json:"body,omitempty"`
 	Issue               *int    `json:"issue,omitempty"`
 	MaintainerCanModify *bool   `json:"maintainer_can_modify,omitempty"`
@@ -282,7 +282,7 @@ type NewPullRequest struct {
 // GitHub API docs: https://docs.github.com/rest/pulls/pulls?apiVersion=2022-11-28#create-a-pull-request
 //
 //meta:operation POST /repos/{owner}/{repo}/pulls
-func (s *PullRequestsService) Create(ctx context.Context, owner, repo string, body *NewPullRequest) (*PullRequest, *Response, error) {
+func (s *PullRequestsService) Create(ctx context.Context, owner, repo string, body CreatePullRequest) (*PullRequest, *Response, error) {
 	u := fmt.Sprintf("repos/%v/%v/pulls", owner, repo)
 	req, err := s.client.NewRequest(ctx, "POST", u, body)
 	if err != nil {