feat: Add Issue Dependencies API support by tommaso-moro · Pull Request #4130 · google/go-github

tommaso-moro · 2026-04-02T14:09:38Z

closes: #4129

Add Issue Dependencies API support

Add support for the Issue Dependencies REST API.

Changes

New file github/issues_dependencies.go adds four methods to IssuesService:

Method	Endpoint	Description
`ListBlockedBy`	`GET /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by`	List dependencies blocking an issue
`AddBlockedBy`	`POST /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by`	Add a blocking dependency
`RemoveBlockedBy`	`DELETE /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by/{issue_id}`	Remove a blocking dependency
`ListBlocking`	`GET /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocking`	List issues this issue is blocking

Also adds IssueDependencyRequest type used by AddBlockedBy.

Testing

Full test coverage in github/issues_dependencies_test.go (12 tests) using standard helpers: testBadOptions, testNewRequestAndDoFailure, testURLParseError, testJSONMarshal.

Auto-generated files updated via go generate: accessors, accessor tests, iterators, and iterator tests.

All scripts pass: script/fmt.sh, script/test.sh, script/lint.sh.

Add four new methods to IssuesService for the Issue Dependencies REST API (apiVersion 2026-03-10): - ListBlockedBy: list dependencies blocking an issue - AddBlockedBy: add a blocking dependency to an issue - RemoveBlockedBy: remove a blocking dependency - ListBlocking: list issues that an issue is blocking Includes IssueDependencyRequest type, full test coverage with testBadOptions, testNewRequestAndDoFailure, testURLParseError, and testJSONMarshal helpers.

Run go generate to add: - GetIssueID accessor for IssueDependencyRequest - ListBlockedBy and ListBlocking iterators with tests

google-cla · 2026-04-02T14:09:50Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

codecov · 2026-04-02T14:18:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.76%. Comparing base (96a3651) to head (14b279b).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4130      +/-   ##
==========================================
+ Coverage   93.74%   93.76%   +0.02%     
==========================================
  Files         211      212       +1     
  Lines       19685    19765      +80     
==========================================
+ Hits        18453    18533      +80     
  Misses       1034     1034              
  Partials      198      198

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis

Thank you, @tommaso-moro!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode

github/issues_dependencies.go

tommaso-moro · 2026-04-08T09:12:21Z

@Not-Dhananjay-Mishra thank you for the review! I have addressed the points you raised and updated this branch.

alexandear · 2026-04-08T10:13:31Z

github/issues.go

+	IssueFieldID       *int64                  `json:"issue_field_id,omitempty"`
+	NodeID             *string                 `json:"node_id,omitempty"`
+	DataType           *string                 `json:"data_type,omitempty"`
+	Value              interface{}             `json:"value,omitempty"`


This should be caught by a linter:

Suggested change

Value interface{} `json:"value,omitempty"`

Value any `json:"value,omitempty"`

alexandear · 2026-04-08T10:35:11Z

github/issues_dependencies.go

+
+// IssueDependencyRequest represents a request to add a dependency to an issue.
+type IssueDependencyRequest struct {
+	IssueID *int64 `json:"issue_id"`


Suggested change

IssueID *int64 `json:"issue_id"`

IssueID int64 `json:"issue_id"`

alexandear · 2026-04-08T10:37:12Z

github/issues_dependencies.go

+// GitHub API docs: https://docs.github.com/rest/issues/issue-dependencies#list-dependencies-an-issue-is-blocked-by
+//
+//meta:operation GET /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by
+func (s *IssuesService) ListBlockedBy(ctx context.Context, owner, repo string, number int, opts *ListOptions) ([]*Issue, *Response, error) {


Suggested change

func (s *IssuesService) ListBlockedBy(ctx context.Context, owner, repo string, number int, opts *ListOptions) ([]*Issue, *Response, error) {

func (s *IssuesService) ListBlockedBy(ctx context.Context, owner, repo string, issueNumber int, opts *ListOptions) ([]*Issue, *Response, error) {

because

alexandear · 2026-04-08T10:37:36Z

github/issues_dependencies.go

+// GitHub API docs: https://docs.github.com/rest/issues/issue-dependencies#add-a-dependency-an-issue-is-blocked-by
+//
+//meta:operation POST /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by
+func (s *IssuesService) AddBlockedBy(ctx context.Context, owner, repo string, number int, issueDepReq IssueDependencyRequest) (*Issue, *Response, error) {


Suggested change

func (s *IssuesService) AddBlockedBy(ctx context.Context, owner, repo string, number int, issueDepReq IssueDependencyRequest) (*Issue, *Response, error) {

func (s *IssuesService) AddBlockedBy(ctx context.Context, owner, repo string, issueNumber int, issueDepReq IssueDependencyRequest) (*Issue, *Response, error) {

alexandear · 2026-04-08T10:38:41Z

github/issues_dependencies.go

+// GitHub API docs: https://docs.github.com/rest/issues/issue-dependencies#remove-dependency-an-issue-is-blocked-by
+//
+//meta:operation DELETE /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by/{issue_id}
+func (s *IssuesService) RemoveBlockedBy(ctx context.Context, owner, repo string, number int, issueID int64) (*Issue, *Response, error) {


Suggested change

func (s *IssuesService) RemoveBlockedBy(ctx context.Context, owner, repo string, number int, issueID int64) (*Issue, *Response, error) {

func (s *IssuesService) RemoveBlockedBy(ctx context.Context, owner, repo string, issueNumber int, issueID int64) (*Issue, *Response, error) {

@gmlewis should we change the type of issueNumber to int64? Because both issue_id and issue_number in the spec is integer.

@gmlewis should we change the type of issueNumber to int64? Because both issue_id and issue_number in the spec is integer.

Yes indeed... thank you for catching that, as well as these other issues, @alexandear! I appreciate it!

alexandear · 2026-04-08T10:39:47Z

github/issues_dependencies.go

+// GitHub API docs: https://docs.github.com/rest/issues/issue-dependencies#list-dependencies-an-issue-is-blocking
+//
+//meta:operation GET /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocking
+func (s *IssuesService) ListBlocking(ctx context.Context, owner, repo string, number int, opts *ListOptions) ([]*Issue, *Response, error) {


Suggested change

func (s *IssuesService) ListBlocking(ctx context.Context, owner, repo string, number int, opts *ListOptions) ([]*Issue, *Response, error) {

func (s *IssuesService) ListBlocking(ctx context.Context, owner, repo string, issueNumber int, opts *ListOptions) ([]*Issue, *Response, error) {

alexandear · 2026-04-08T10:43:17Z

github/issues_dependencies_test.go

+		var v IssueDependencyRequest
+		assertNilError(t, json.NewDecoder(r.Body).Decode(&v))
+
+		testMethod(t, r, "POST")
+		if !cmp.Equal(v, input) {
+			t.Errorf("Request body = %+v, want %+v", v, input)
+		}


Suggested change

var v IssueDependencyRequest

assertNilError(t, json.NewDecoder(r.Body).Decode(&v))

testMethod(t, r, "POST")

if !cmp.Equal(v, input) {

t.Errorf("Request body = %+v, want %+v", v, input)

}

testMethod(t, r, "POST")

testBody(t, r, `{"issue_id":42}` + "\n")

tommaso-moro added 2 commits April 2, 2026 11:27

chore: Regenerate accessors and iterators

9aba995

Run go generate to add: - GetIssueID accessor for IssueDependencyRequest - ListBlockedBy and ListBlocking iterators with tests

tommaso-moro mentioned this pull request Apr 2, 2026

Add support for Issue Dependencies REST API #4129

Open

tommaso-moro marked this pull request as ready for review April 2, 2026 14:46

chore: trigger CI

f57a237

gmlewis approved these changes Apr 2, 2026

View reviewed changes

gmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 2, 2026

Not-Dhananjay-Mishra reviewed Apr 3, 2026

View reviewed changes

github/issues_dependencies.go Outdated Show resolved Hide resolved

github/issues_dependencies.go Outdated Show resolved Hide resolved

github/issues_dependencies.go Show resolved Hide resolved

tommaso-moro and others added 4 commits April 3, 2026 11:49

remove omitempty for required param

76cfab3

pass by value instead of reference as param is required

4550de5

add missing fields to Issue struct

13f260e

Merge branch 'master' into tommy/issue-dependencies-support

14b279b

tommaso-moro requested review from Not-Dhananjay-Mishra and gmlewis April 8, 2026 09:11

munlicode approved these changes Apr 8, 2026

View reviewed changes

alexandear reviewed Apr 8, 2026

View reviewed changes

alexandear suggested changes Apr 8, 2026

View reviewed changes

	Value interface{} `json:"value,omitempty"`
	Value any `json:"value,omitempty"`

	IssueID *int64 `json:"issue_id"`
	IssueID int64 `json:"issue_id"`

	func (s IssuesService) ListBlockedBy(ctx context.Context, owner, repo string, number int, opts ListOptions) ([]Issue, Response, error) {
	func (s IssuesService) ListBlockedBy(ctx context.Context, owner, repo string, issueNumber int, opts ListOptions) ([]Issue, Response, error) {

	func (s IssuesService) AddBlockedBy(ctx context.Context, owner, repo string, number int, issueDepReq IssueDependencyRequest) (Issue, *Response, error) {
	func (s IssuesService) AddBlockedBy(ctx context.Context, owner, repo string, issueNumber int, issueDepReq IssueDependencyRequest) (Issue, *Response, error) {

	func (s IssuesService) RemoveBlockedBy(ctx context.Context, owner, repo string, number int, issueID int64) (Issue, *Response, error) {
	func (s IssuesService) RemoveBlockedBy(ctx context.Context, owner, repo string, issueNumber int, issueID int64) (Issue, *Response, error) {

	func (s IssuesService) ListBlocking(ctx context.Context, owner, repo string, number int, opts ListOptions) ([]Issue, Response, error) {
	func (s IssuesService) ListBlocking(ctx context.Context, owner, repo string, issueNumber int, opts ListOptions) ([]Issue, Response, error) {

Conversation

tommaso-moro commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add Issue Dependencies API support

Changes

Testing

Uh oh!

google-cla bot commented Apr 2, 2026

Uh oh!

codecov bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tommaso-moro commented Apr 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tommaso-moro commented Apr 2, 2026 •

edited

Loading

codecov bot commented Apr 2, 2026 •

edited

Loading