refactor: Add constants for API versions#4236
Merged
gmlewis merged 2 commits intoMay 19, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4236 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 189 189
Lines 19164 19164
=======================================
Hits 18677 18677
Misses 270 270
Partials 217 217 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
reviewed
May 19, 2026
| uploadBaseURL = "https://uploads.github.com/" | ||
| // https://docs.github.com/en/rest/about-the-rest-api/api-versions#about-api-versioning | ||
| defaultAPIVersion = api20221128 | ||
| latestAPIVersion = api20260310 |
Collaborator
There was a problem hiding this comment.
Why do we need latestAPIVersion if it is never used anywhere and just exists to be a maintenance burden to update as simply being informative?
Contributor
Author
There was a problem hiding this comment.
It's for the future use. But I can remove it for now.
I thought it's better to add a constant instead of commenting that 2026 is the latest API.
Contributor
There was a problem hiding this comment.
It might help provide context (for agents) too.
gmlewis
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #4225 (comment)
cc: @stevehipwell