Change NestingCounter into NestingStack.#1363
Merged
copybara-service[bot] merged 1 commit intomasterfrom Apr 2, 2026
Merged
Conversation
Although most uses will effectively be an expensive counter, with a stack where every element is `Integer.valueOf(1)`, the introduction of Markdown support will mean some uses where that is not the case. For example, the continuing indentation of list items will depend on whether they are HTML lists or Markdown lists, and for Markdown lists it will further depend on the list type. For now, implement the indentation of `<ul>` (etc) and `<li>` using the stack rather than multiplications. PiperOrigin-RevId: 893521393
copybara-service
bot
force-pushed
the
test_893169638
branch
from
7ed7a4a to
142c392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
NestingCounterintoNestingStack.Although most uses will effectively be an expensive counter, with a stack where every element is
Integer.valueOf(1), the introduction of Markdown support will mean some uses where that is not the case. For example, the continuing indentation of list items will depend on whether they are HTML lists or Markdown lists, and for Markdown lists it will further depend on the list type.For now, implement the indentation of
<ul>(etc) and<li>using the stack rather than multiplications.