Add assert_true! and assert_false! macros to gtest_rust#801
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_910544641
branch
6 times, most recently
from
234aeed to
66700a1
Compare
These macros provide fatal assertions, panicking if the condition is not met. This aligns with the assertion a developer would expect from other test frameworks. The macros are added to `assertions.rs` and exported in `lib.rs`. Integration tests are added to: - `passing_tests.rs`: Ensure the macros don't panic when the condition is met. - `failing_tests.rs`: Ensure the macros *do* panic when the condition is not met. - `integration_tests.sh`: Updated to expect the new failures in `failing_tests_bin`. PUBLIC: Add assert_true! and assert_false! macros for fatal assertions. PiperOrigin-RevId: 913525450
copybara-service
Bot
force-pushed
the
test_910544641
branch
from
66700a1 to
0925bc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add assert_true! and assert_false! macros to gtest_rust
These macros provide fatal assertions, panicking if the condition is not met. This aligns with the assertion a developer would expect from other test frameworks.
The macros are added to
assertions.rsand exported inlib.rs.Integration tests are added to:
passing_tests.rs: Ensure the macros don't panic when the condition is met.failing_tests.rs: Ensure the macros do panic when the condition is not met.integration_tests.sh: Updated to expect the new failures infailing_tests_bin.PUBLIC: Add assert_true! and assert_false! macros for fatal assertions.