Add test for creating a container within a sandbox.#13225
Merged
Conversation
copybara-service
Bot
force-pushed
the
test/cl918623969
branch
from
f3f9bba to
c127cc2
Compare
Refactor TestCreateSandbox to use helper functions for creating, starting, and killing containers, which wait for the expected task states. Add TestCreateSandboxWithContainer to verify the workflow of creating a sandbox, then creating and starting a container inside it, and finally killing the sandbox. Update shimutils.NewContainerSpec to accept a sandboxID. PiperOrigin-RevId: 919866693
copybara-service
Bot
force-pushed
the
test/cl918623969
branch
from
c127cc2 to
93dff94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test for creating a container within a sandbox.
Refactor TestCreateSandbox to use helper functions for creating, starting, and
killing containers, which wait for the expected task states. Add
TestCreateSandboxWithContainer to verify the workflow of creating a sandbox,
then creating and starting a container inside it, and finally killing
the sandbox. Update shimutils.NewContainerSpec to accept a sandboxID.