Skip to content

Resolve TODOs from #2157 #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crockeea wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −9
Open

Resolve TODOs from #2157 #2977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/Dialect/Polynomial/Conversions/PolynomialToModArith/PolynomialToModArith.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1610,7 +1610,6 @@ void PolynomialToModArith::runOnOperation() {

ConversionConfig config;
config.allowPatternRollback = false;
config.buildMaterializations = buildMaterializations;
if (failed(applyPartialConversion(module, target, std::move(patterns),
config))) {
signalPassFailure();
Expand Down
6 changes: 0 additions & 6 deletions lib/Dialect/Polynomial/Conversions/PolynomialToModArith/PolynomialToModArith.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@ def PolynomialToModArith : Pass<"polynomial-to-mod-arith", "ModuleOp"> {
"mlir::scf::SCFDialect",
"mlir::tensor::TensorDialect",
];

// TODO(#2157): Remove option once key_switch_inner lowering is done
let options = [
Option<"buildMaterializations", "build-materializations", "bool", /*default=*/"true",
"Whether to build materializations">,
];
}

#endif // LIB_DIALECT_POLYNOMIAL_CONVERSIONS_POLYNOMIALTOMODARITH_POLYNOMIALTOMODARITH_TD_
2 changes: 0 additions & 2 deletions tests/Dialect/Polynomial/Conversions/polynomial_to_mod_arith/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,5 @@ glob_lit_tests(
name = "all_tests",
data = ["@heir//tests:test_utilities"],
driver = "@heir//tests:run_lit.sh",
# TODO(#2157): re-enable when the rest of key_switch_inner is lowered
exclude = ["lower_keyswitch_inner.mlir"],
test_file_exts = ["mlir"],
)
Loading