Attempted workaround for GCC PPC EMU128 test failure, refs #3024#3027
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_908194619
branch
from
5318326 to
908ae35
Compare
bkmgit
reviewed
May 2, 2026
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Clang aarch64 OOM workaround: Not using AES, hence NEON_WITHOUT_AES is |
Contributor
There was a problem hiding this comment.
Should this be GCC instead of Clang?
Member
There was a problem hiding this comment.
Fair :) I copied from existing code, we've had the same problem on Clang, but this instance was indeed GCC.
bkmgit
reviewed
May 2, 2026
| alignas(16) T lanes[N128]; | ||
| for (size_t i = 0; i < N128; ++i) { | ||
| lanes[i] = ConvertScalarTo<T>(1 + i); | ||
| lanes[i] = ConvertScalarTo<T>(hwy::Unpredictable1() + i); |
Contributor
There was a problem hiding this comment.
This does not seem to fix the problem. It is likely a compiler bug specific to GCC 16 on ppc 64.
Code compiles fine on GCC15:
https://copr.fedorainfracloud.org/coprs/fed500/highway/build/10415978/
Initial report:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=125148
Member
There was a problem hiding this comment.
hm :/ Thanks for filing the report. There is no harm in using Unpredictable1, this prevents test code from being optimized out and we're slowly moving toward that everywhere.
copybara-service
Bot
force-pushed
the
test_908194619
branch
from
908ae35 to
e768493
Compare
Add Unpredictable1 instead of literal Also disable some aarch64 targets for compare_test to prevent OOM PiperOrigin-RevId: 909853992
copybara-service
Bot
force-pushed
the
test_908194619
branch
from
e768493 to
bb1c16b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempted workaround for GCC PPC EMU128 test failure, refs #3024
Add Unpredictable1 instead of literal
Also disable some aarch64 targets for compare_test to prevent OOM