Fix dispatch mismatch in sort_test vs vqsort, fixes #3188#3190
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_942159491
branch
3 times, most recently
from
July 4, 2026 06:12
aa5ce94 to
3e6baa2
Compare
VQSort is compiled with its own dispatch table whereas the test is compiled for all targets. This means SCALAR thinks f64 is supported and calls vqsort, which has no target supporting f64, causing an assert. Instead create new HaveFloat16/64 accessors that return the actual status for which VQSort was compiled. Also update armv7 compiler for test. PiperOrigin-RevId: 942376939
copybara-service
Bot
force-pushed
the
test_942159491
branch
from
July 4, 2026 06:22
3e6baa2 to
4f84616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dispatch mismatch in sort_test vs vqsort, fixes #3188
VQSort is compiled with its own dispatch table whereas the test is compiled for all targets. This means SCALAR thinks f64 is supported and calls vqsort, which has no target supporting f64, causing an assert.
Instead create new HaveFloat16/64 accessors that return the actual status for which VQSort was compiled.
Also update armv7 compiler for test.