Skip to content

Commit 50ce1b2

Browse files
lauraharkercopybara-github
authored andcommitted
Sort integer_entities.txt & update GeneratorUtils to support '#' comments
PiperOrigin-RevId: 927447699
1 parent 769ec02 commit 50ce1b2

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

java/jsinterop/generator/helper/GeneratorUtils.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@
2020
import static com.google.common.base.CaseFormat.UPPER_CAMEL;
2121
import static com.google.common.base.Preconditions.checkNotNull;
2222
import static com.google.common.base.Strings.isNullOrEmpty;
23+
import static com.google.common.collect.ImmutableList.toImmutableList;
2324
import static com.google.common.collect.Iterables.transform;
2425
import static java.util.stream.Collectors.joining;
2526

2627
import com.google.common.base.Joiner;
2728
import com.google.common.base.Splitter;
29+
import com.google.common.collect.ImmutableList;
2830
import java.io.IOException;
2931
import java.util.List;
3032
import java.util.Map;
@@ -142,8 +144,12 @@ public static Map<String, String> readKeyValueFiles(
142144
.split(readFiles(filePaths, fileReader));
143145
}
144146

145-
public static List<String> readListFiles(List<String> filePaths, FileReader fileReader) {
146-
return Splitter.on('\n').omitEmptyStrings().splitToList(readFiles(filePaths, fileReader));
147+
public static ImmutableList<String> readListFiles(List<String> filePaths, FileReader fileReader) {
148+
return Splitter.on('\n')
149+
.omitEmptyStrings()
150+
.splitToStream(readFiles(filePaths, fileReader))
151+
.filter(line -> !line.startsWith("#"))
152+
.collect(toImmutableList());
147153
}
148154

149155
private static String readFiles(List<String> filePaths, FileReader reader) {

0 commit comments

Comments
 (0)