Revert "Check return value of TableBuilder::Add() in compaction routine."

This reverts commit 80d6c09.

Author: Evan Stade

db/db_impl.cc

@@ -1004,12 +1004,7 @@ Status DBImpl::DoCompactionWork(CompactionState* compact) {
         compact->current_output()->smallest.DecodeFrom(key);
       }
       compact->current_output()->largest.DecodeFrom(key);
-
-      status = compact->builder->Add(key, input->value());
-      if (!status.ok()) {
-        FinishCompactionOutputFile(compact, input);
-        break;
-      }
+      compact->builder->Add(key, input->value());
 
       // Close output file if it is big enough
       if (compact->builder->FileSize() >=

include/leveldb/table_builder.h

@@ -49,7 +49,7 @@ class LEVELDB_EXPORT TableBuilder {
   // Add key,value to the table being constructed.
   // REQUIRES: key is after any previously added key according to comparator.
   // REQUIRES: Finish(), Abandon() have not been called
-  Status Add(const Slice& key, const Slice& value);
+  void Add(const Slice& key, const Slice& value);
 
   // Advanced operation: flush any buffered key/value pairs to file.
   // Can be used to ensure that two adjacent entries never live in

table/table_builder.cc

@@ -91,12 +91,10 @@ Status TableBuilder::ChangeOptions(const Options& options) {
   return Status::OK();
 }
 
-Status TableBuilder::Add(const Slice& key, const Slice& value) {
+void TableBuilder::Add(const Slice& key, const Slice& value) {
   Rep* r = rep_;
   assert(!r->closed);
-  if (!ok()) {
-    return status();
-  }
+  if (!ok()) return;
   if (r->num_entries > 0) {
     assert(r->options.comparator->Compare(key, Slice(r->last_key)) > 0);
   }
@@ -122,7 +120,6 @@ Status TableBuilder::Add(const Slice& key, const Slice& value) {
   if (estimated_block_size >= r->options.block_size) {
     Flush();
   }
-  return status();
 }
 
 void TableBuilder::Flush() {