Fix short SequentialFile reads that could drop WAL/MANIFEST data#1334
Open
uadhran wants to merge 2 commits into
Open
Fix short SequentialFile reads that could drop WAL/MANIFEST data#1334uadhran wants to merge 2 commits into
uadhran wants to merge 2 commits into
Conversation
PosixSequentialFile and WindowsSequentialFile now retry reads until the requested byte count is satisfied or EOF is reached. log::Reader also accumulates partial block reads so custom Env implementations are safe. Adds PartialReadSourceTest to verify multi-block log recovery when reads return fewer bytes than requested before EOF. Related: google#1285
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
uadhran
marked this pull request as ready for review
June 11, 2026 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a data-loss risk when
SequentialFile::Read()returns a successful short read before EOF (e.g. POSIXread()interrupted by a signal after partially filling the buffer).log::Readerpreviously treated any short read as EOF, which could silently drop MANIFEST or WAL data duringDB::Open().Changes
util/env_posix.cc:PosixSequentialFile::Readloops untilnbytes are read or EOF.util/env_windows.cc: Same retry loop forWindowsSequentialFile::Read.db/log_reader.cc:ReadPhysicalRecordaccumulates partial block reads before treating EOF.include/leveldb/env.h: Document that implementations should only return short reads at EOF.db/log_test.cc: AddPartialReadSourceTestregression test; updateStringSourcemock to match real EOF semantics.Testing
Built and ran on Linux (CMake Release):
Did not run Windows or macOS CI matrix locally.
Related: #1285