Skip to content

Commit f916917

Browse files
Merge branch 'google:master' into rename-nongeographicalregion
2 parents ae42ce6 + dfdc8e4 commit f916917

178 files changed

Lines changed: 33192 additions & 32756 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
2+
# Copyright 2024 Google LLC
3+
#
4+
# Licensed under the Apache License, Version 2.0 (the "License");
5+
# you may not use this file except in compliance with the License.
6+
# You may obtain a copy of the License at
7+
#
8+
# http://www.apache.org/licenses/LICENSE-2.0
9+
#
10+
# Unless required by applicable law or agreed to in writing, software
11+
# distributed under the License is distributed on an "AS IS" BASIS,
12+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
# See the License for the specific language governing permissions and
14+
# limitations under the License.
15+
16+
name: OSV-Scanner
17+
18+
on:
19+
pull_request:
20+
branches: ["master"]
21+
schedule:
22+
- cron: "12 12 * * 1"
23+
push:
24+
branches: ["master"]
25+
26+
permissions:
27+
# Required to upload SARIF file to CodeQL. See: https://github.com/github/codeql-action/issues/2117
28+
actions: read
29+
# Require writing security events to upload SARIF file to security tab
30+
security-events: write
31+
# Read commit contents
32+
contents: read
33+
34+
jobs:
35+
scan-scheduled:
36+
if: ${{ github.event_name == 'push' || github.event_name == 'schedule' }}
37+
# If you want to copy this config, highly suggest pinning this version to a release rather than tracking the main branch
38+
uses: google/osv-scanner-action/.github/workflows/osv-scanner-reusable.yml@c80d3cb8d7bfabae9f047f6b8ea68792dd2ebcf6 # v1.9.0
39+
scan-pr:
40+
if: ${{ github.event_name == 'pull_request' || github.event_name == 'merge_group' }}
41+
# If you want to copy this config, highly suggest pinning this version to a release rather than tracking the main branch
42+
uses: google/osv-scanner-action/.github/workflows/osv-scanner-reusable-pr.yml@c80d3cb8d7bfabae9f047f6b8ea68792dd2ebcf6 # v1.9.0

FALSEHOODS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ surprising how many false assumptions programmers continue to make about them.
249249
countries a leading 0 is significant and forms part of the number itself
250250
(see *A leading zero in numbers formatted for domestic usage can always be
251251
discarded when dialing from abroad*). Moreover, a phone number may contain
252-
other diallable characters (see *Phone numbers contain only digits*) or an
252+
other dialable characters (see *Phone numbers contain only digits*) or an
253253
extension portion, dialled after waiting for a tone.
254254

255255
**Tip:** Use the library to parse and format numbers to handle this

FAQ.md

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -362,20 +362,9 @@ right thing if the phone number object is as intended.
362362
@Mexico,
363363
Mexico used to have such additional prefixes (1, 02, 045, ...) for dialling
364364
mobile numbers internationally, fixed-line to mobile nationally.. As these
365-
dialling patterns were deprecated, we have continued to maintain mobile and
365+
dialling patterns were deprecated, we removed them but still maintain mobile and
366366
fixed-line ranges at higher level, returning type as [`FIXED_LINE_OR_MOBILE`](#fixed_line_or_mobile)
367367

368-
### <a href="#mx_legacy_formats">Why Mexico (MX) numbers in older dialling formats are accepted as valid ones?</a>
369-
Though library has stopped supporting below older dialling codes in the canonical
370-
form and formatting results, we are lenient in parsing the number, i.e removing
371-
all older codes.
372-
- 1 -> in E.164 international diallings
373-
- 01, 02, 044 and 045 -> for local/national diallings
374-
375-
This is because we found the older dialling codes supported even after deprecation
376-
period, so we decided to support them for longer time. However, we will stop this as
377-
part of [this issue](https://issuetracker.google.com/issues/205606725). More details there.
378-
379368
### <a name="#unsupported_regions">Why are Bouvet Island (BV), Pitcairn Island (PN), Antarctica (AQ) etc. not supported?</a>
380369

381370
We only support a country if:

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ Cream Sandwich).
5555
The [Java demo](https://libphonenumber.appspot.com/) is updated with a slight
5656
delay after the GitHub release.
5757

58-
Last demo update: v8.13.47.
58+
Last demo update: v8.13.50.
5959

6060
Note: Even though the library (main branch/[maven release](https://repo1.maven.org/maven2/com/googlecode/libphonenumber/libphonenumber/8.12.56/))
6161
is at v8.12.57, because of some deployment issues, we were unable to update the

cpp/src/phonenumbers/lite_metadata.cc

Lines changed: 13537 additions & 13501 deletions
Large diffs are not rendered by default.

cpp/src/phonenumbers/metadata.cc

Lines changed: 13089 additions & 13049 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)