Skip to content

Commit 5a4ba10

Browse files
authored
Upgrade GitHub Actions for Node 24 compatibility (#5133)
1 parent cc79ea8 commit 5a4ba10

4 files changed

Lines changed: 7 additions & 6 deletions

File tree

.github/workflows/deploy-documentation.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ jobs:
1414
timeout-minutes: 60
1515

1616
steps:
17-
- uses: actions/checkout@v4
17+
- uses: actions/checkout@v6
1818
with:
1919
submodules: true
2020

21-
- uses: actions/setup-node@v4
21+
- uses: actions/setup-node@v6
2222

2323
- name: NPM install
2424
run: npm ci

.github/workflows/fidelity-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ jobs:
88
timeout-minutes: 90
99

1010
steps:
11-
- uses: actions/checkout@v4
11+
- uses: actions/checkout@v6
1212
with:
1313
submodules: true
1414

15-
- uses: actions/setup-node@v4
15+
- uses: actions/setup-node@v6
1616

1717
- name: NPM install
1818
run: npm ci

.github/workflows/unit-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ jobs:
99
timeout-minutes: 60
1010

1111
steps:
12-
- uses: actions/checkout@v4
12+
- uses: actions/checkout@v6
1313
with:
1414
submodules: true
1515

16-
- uses: actions/setup-node@v4
16+
- uses: actions/setup-node@v6
1717

1818
- name: NPM install
1919
run: npm ci

packages/model-viewer/src/test/features/annotation-spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,7 @@ suite('Annotation', () => {
236236

237237
test('gets expected hit result when turned', async () => {
238238
element.resetTurntableRotation(-Math.PI / 2);
239+
element[$scene].updateMatrixWorld();
239240
await rafPasses();
240241
const hitResult = element.positionAndNormalFromPoint(
241242
rect.width / 2 + rect.x, rect.height / 2 + rect.y);

0 commit comments

Comments
 (0)