feat: support length units in extra-model offset#5180
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
`updateModelTransforms` parsed `<extra-model offset="...">` with a plain `split`/`Number`, so only unitless numbers (meters) worked. Parse the value with `parseExpressions`/`normalizeUnit` instead, mirroring the `orientation` handling, so each component may carry a length unit (`m`/`cm`/`mm`) while bare numbers continue to be treated as meters (e.g. `offset="-2.0 0 0"` and `offset="-200cm 0 0"` are equivalent). Document offset unit support and the existing roll/pitch/yaw orientation convention on the multimodel example, and update the property JSDoc. Add a test covering unit-suffixed offsets and that bare numbers stay in meters.
Frank3K
force-pushed
the
feat/extra-model-offset-units
branch
from
68f4f2c to
538cd0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
updateModelTransformsparsed<extra-model offset="...">with a plainsplit/Number, so only unitless numbers (meters) worked. Parse the value withparseExpressions/normalizeUnitinstead, mirroring theorientationhandling, so each component may carry a length unit (m/cm/mm) while bare numbers continue to be treated as meters (e.g.offset="-2.0 0 0"andoffset="-200cm 0 0"are equivalent).Document offset unit support and the existing roll/pitch/yaw orientation convention on the multimodel example, and update the property JSDoc.
Add a test covering unit-suffixed offsets and that bare numbers stay in meters.