Remove leftover debug console.log statements#5182
Merged
diegoteran merged 1 commit intoJun 18, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Several debug `console.log` calls were left in and ship in 4.3.x, spamming
the browser console on normal use: on every page load the model-viewer base
logs `[onExtraModelChanged]`, `IntersectionObserver fired!`,
`[$updateSource] called!` and `[$updateSource] BAILING OUT EARLY!`, the AR
flow logs `Attempting to present in AR with ...`, and ARRenderer logs
`[processInput] Setting goalPosition.y ...`.
Remove these developer debug logs. The genuine error diagnostic in
Renderer.ts ("could not acquire 2d context") is left untouched.
tiagonrodrigues
force-pushed
the
remove-leftover-debug-logging
branch
from
c8fdec9 to
cb89a5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5181.
Several debug
console.logcalls were left in and ship in4.3.x, spamming the browser console on normal use.On every page load,
model-viewer-baselogs[onExtraModelChanged],IntersectionObserver fired!,[$updateSource] called!and[$updateSource] BAILING OUT EARLY!. The AR flow logsAttempting to present in AR with WebXR/Scene Viewer/Quick Look..., andARRendererlogs[processInput] Setting goalPosition.y ....This removes those developer debug logs (14 lines across 3 files). The genuine error diagnostic in
Renderer.ts(could not acquire 2d context) is intentionally left untouched.No behavior change beyond removing console output.