Skip to content

Remove leftover debug console.log statements #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegoteran merged 1 commit into from
Jun 18, 2026
Merged

Remove leftover debug console.log statements #5182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/model-viewer/src/features/ar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,6 @@ configuration or device capabilities');
}

protected async[$enterARWithWebXR]() {
console.log('Attempting to present in AR with WebXR...');

await this[$triggerLoad]();

try {
Expand Down Expand Up @@ -395,7 +393,6 @@ configuration or device capabilities');
self.addEventListener('hashchange', undoHashChange, {once: true});

this[$arAnchor].setAttribute('href', intent);
console.log('Attempting to present in AR with Scene Viewer...');
this[$arAnchor].click();
}

Expand Down Expand Up @@ -450,7 +447,6 @@ configuration or device capabilities');
if (!anchor.isConnected)
this.shadowRoot!.appendChild(anchor);

console.log('Attempting to present in AR with Quick Look...');
anchor.click();
anchor.removeChild(img);
if (generateUsdz) {
Expand Down
9 changes: 0 additions & 9 deletions packages/model-viewer/src/model-viewer-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,6 @@ export default class ModelViewerElementBase extends ReactiveElement {
const extraModels = Array.from(this.querySelectorAll('extra-model'));
const childIndex = (extraModels as HTMLElement[]).indexOf(targetNode);

console.log(`[onExtraModelChanged] childIndex: ${childIndex} srcChanged: ${
customEv.detail.srcChanged} offset: ${customEv.detail.offset}`);

if (childIndex === -1)
return;

Expand Down Expand Up @@ -349,8 +346,6 @@ export default class ModelViewerElementBase extends ReactiveElement {
const oldVisibility = this.modelIsVisible;
this[$isElementInViewport] = entry.isIntersecting;
this[$announceModelVisibility](oldVisibility);
console.log(`IntersectionObserver fired! isIntersecting: ${
entry.isIntersecting}`);
if (this[$isElementInViewport] && !this.loaded) {
this[$updateSource]();
}
Expand Down Expand Up @@ -681,12 +676,8 @@ export default class ModelViewerElementBase extends ReactiveElement {
const extraUrlsMatch =
extraUrlsList.join(',') === (scene.extraUrls || []).join(',');

console.log(`[$updateSource] called! \nsrc: ${this.src}\nextraUrls: ${
extraUrlsList.join(',')}\nloaded: ${this.loaded}`);

if (this.loaded || !this[$shouldAttemptPreload]() ||
(this.src === scene.url && extraUrlsMatch)) {
console.log('[$updateSource] BAILING OUT EARLY!');
return;
}

Expand Down
1 change: 0 additions & 1 deletion packages/model-viewer/src/three-components/ARRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,7 +1068,6 @@ export class ARRenderer extends EventDispatcher<
// control
if (this.isWorldSpaceReady()) {
// Use the hit point directly without floor constraints
console.log('[processInput] Setting goalPosition.y to hit.y:', hit.y);
this.goalPosition.add(hit);
} else if (this.placeOnWall === false) {
// Original logic for screen-space or initial world-space placement
Expand Down
Loading