fix: enable Quick Look AR in third-party iOS browsers without ios-src#5188
Merged
diegoteran merged 1 commit intoJul 7, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The AR button stopped appearing in Chrome (and Edge/Firefox/DuckDuckGo) on iOS unless an explicit `ios-src` was provided. Those browsers can launch Quick Look with model-viewer's auto-generated USDZ, so the `ios-src` requirement is unnecessary and regressed behavior that worked in 4.2.0. Drop the `(!IS_IOS_THIRDPARTY || this.iosSrc != null)` clause from the quick-look mode selection. Quick Look remains disabled in the Google Search App webview (`!IS_IOS_GSA`), where it is genuinely broken. Fixes google#5185
Frank3K
force-pushed
the
fix/quick-look-ios-thirdparty-browsers
branch
from
8591589 to
1488060
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The AR button stopped appearing in Chrome (and Edge/Firefox/DuckDuckGo) on iOS unless an explicit
ios-srcwas provided. Those browsers can launch Quick Look with model-viewer's auto-generated USDZ, so theios-srcrequirement is unnecessary and regressed behavior that worked in 4.2.0.Drop the
(!IS_IOS_THIRDPARTY || this.iosSrc != null)clause from the quick-look mode selection. Quick Look remains disabled in the Google Search App webview (!IS_IOS_GSA), where it is genuinely broken.Reference Issue
Fixes #5185