Skip to content

Fix preedit decoration in ibus-mozc under Wayland#1485

Open
ftake wants to merge 1 commit into
google:masterfrom
ftake:ibus-semantic-preedit-hints
Open

Fix preedit decoration in ibus-mozc under Wayland#1485
ftake wants to merge 1 commit into
google:masterfrom
ftake:ibus-semantic-preedit-hints

Conversation

@ftake
Copy link
Copy Markdown
Contributor

@ftake ftake commented Apr 25, 2026

Description

Wayland protocols do not support specifying arbitrary RGB colors for preedit styling. This commit switchs preedidt decoration to IBus semantic preedit hints (available since 1.5.33) so that decoration works correctly under Wayland.

Issue IDs

#1484

Steps to test new behaviors (if any)

A clear and concise description about how to verify new behaviors (if any).

  • OS: Linux, Plasma Wayland
  • Steps:
    1. Open Kate
    2. Type Watashinonamaeha
    3. Type Space
    4. Check the first segment is highlighted

Additional context

  • This fix requires newer IBus (1.5.33). If necessary, we can keep some codes for backward compatibility.
  • This change affects X11 session. The highlight color will be changed from #D1EAFF to IBus's default.

Wayland protocols do not support specifying arbitrary RGB colors for preedit styling. This commit switchs preedidt decoration to IBus semantic preedit hints (available since 1.5.33) so that decoration works correctly under Wayland.
@yukawa
Copy link
Copy Markdown
Collaborator

yukawa commented Apr 25, 2026

This fix requires newer IBus (1.5.33). If necessary, we can keep some codes for backward compatibility.

Our CI relies on Ubuntu 24.04, where IBus 1.5.29 seems to be used. Does your change break our CI? If yes, I think the answer is clear and we need to keep the backward compatibility.

build:
# https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md
runs-on: ubuntu-24.04
timeout-minutes: 60

@ftake
Copy link
Copy Markdown
Contributor Author

ftake commented Apr 25, 2026

Does your change break our CI?

Yes...
Is there any plan to update the CI environment to Ubuntu 26.04?

@yukawa
Copy link
Copy Markdown
Collaborator

yukawa commented Apr 25, 2026

Is there any plan to update the CI environment to Ubuntu 26.04?

Yes, we are going to update to Ubuntu 26.04 when it becomes available. See the following tasks when we updated our CI Ubuntu version in the past.

That said chances are high that GitHub will not release new Ubuntu version soon. As for Ubuntu 26.04, it was September 25 when it became GA.

I think keeping backward compatibility is a realistic path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants