Remove Singleton from stats_config_util.cc#1509
Open
yukawa wants to merge 1 commit into
Open
Conversation
As part of our ongoing efforts to remove the dependency on Singleton, this commit rewrites config/stats_config_util.cc without the Singleton class dependency. There should be no user observable change, including the fact that OSS builds have been fixed to use NullStatsConfigUtilImpl at build time.
yukawa
force-pushed
the
remove_singleton_from_stats_config_util
branch
from
295c5cd to
1607af5
Compare
yukawa
changed the title
Singleton from config::StatsConfigUtilSingleton from stats_config_util.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of our ongoing efforts to remove the dependency on
Singleton, this commit rewritesconfig/stats_config_util.ccwithout the Singleton class dependency.There should be no user observable change, including the fact that OSS builds have been fixed to use
NullStatsConfigUtilImplat build time.Issue IDs
N/A
Steps to test new behaviors (if any)
bazelisk test //config:stats_config_util_test