js: add integer encoding tests

Author: drinckes

js/README.md

@@ -30,7 +30,10 @@ Unit tests require [gulp](https://www.npmjs.com/package/gulp),
 [karma](https://karma-runner.github.io) and
 [jasmine](https://jasmine.github.io).
 
-Execute the tests with `npm test`. This will install the
+To run the tests the first time use `bash checks.sh` - this will convert the
+CSV test files to JSON.
+
+Then you can execute the tests with `npm test`. This will install the
 dependencies, run `eslint` and then run the tests as long as there were no
 eslint errors.
 

js/src/openlocationcode.js

@@ -345,7 +345,7 @@
    * @param {number} longitude
    * @return {Array<number>} A tuple of the latitude integer and longitude integer.
    */
-  var locationToIntegers = function(latitude, longitude) {
+  var locationToIntegers = OpenLocationCode.locationToIntegers = function(latitude, longitude) {
     var latVal = roundAwayFromZero(latitude * FINAL_LAT_PRECISION_);
     latVal += LATITUDE_MAX_ * FINAL_LAT_PRECISION_;
     if (latVal < 0) {
@@ -377,7 +377,7 @@
    * @return {string} A code of the specified length or the default length if not
    *     specified.
    */
-  var encodeIntegers = function(latInt, lngInt, codeLength) {
+  var encodeIntegers = OpenLocationCode.encodeIntegers = function(latInt, lngInt, codeLength) {
     // Javascript strings are immutable and it doesn't have a native
     // StringBuilder, so we'll use an array.
     const code = new Array(MAX_DIGIT_COUNT_ + 1);

js/test/jasmine-tests.js

@@ -7,9 +7,33 @@ describe("Open Location Code", function() {
     expect(encTests.length).toBeGreaterThan(1);
     for (var i = 0; i < encTests.length; i++) {
       var test = encTests[i];
-      var code = OpenLocationCode.encode(test[0], test[1], test[2]);
+      var code = OpenLocationCode.encode(test[0], test[1], test[4]);
       // Did we get the same code?
-      expect(code).toBe(test[3]);
+      expect(code).toBe(test[5]);
+    }
+  });
+
+  it("Location to Integers Tests", function() {
+    jasmine.getFixtures().fixturesPath = 'base/';
+    var encTests = JSON.parse(jasmine.getFixtures().read("encoding.json"));
+    expect(encTests.length).toBeGreaterThan(1);
+    for (var i = 0; i < encTests.length; i++) {
+      var test = encTests[i];
+      var got = OpenLocationCode.locationToIntegers(test[0], test[1]);
+      expect(got[0]).toBe(test[2]);
+      expect(got[1]).toBe(test[3]);
+    }
+  });
+
+  it("Integer Encoding Tests", function() {
+    jasmine.getFixtures().fixturesPath = 'base/';
+    var encTests = JSON.parse(jasmine.getFixtures().read("encoding.json"));
+    expect(encTests.length).toBeGreaterThan(1);
+    for (var i = 0; i < encTests.length; i++) {
+      var test = encTests[i];
+      var code = OpenLocationCode.encodeIntegers(test[2], test[3], test[4]);
+      // Did we get the same code?
+      expect(code).toBe(test[5]);
     }
   });