Add validity tests to cover edge cases

This improves Go coverage for optimizations I want to be sure are safe.

Author: willbeason

go/olc.go

@@ -167,9 +167,6 @@ func CheckFull(code string) error {
 	if firstLat := strings.IndexByte(Alphabet, upper(code[0])) * int(encBase); firstLat >= latMax*2 {
 		return errors.New("latitude outside range")
 	}
-	if len(code) == 1 {
-		return nil
-	}
 	if firstLong := strings.IndexByte(Alphabet, upper(code[1])) * int(encBase); firstLong >= lngMax*2 {
 		return errors.New("longitude outside range")
 	}

go/olc_test.go

@@ -131,6 +131,36 @@ func TestCheck(t *testing.T) {
 	}
 }
 
+func TestCheckShort(t *testing.T) {
+	for i, elt := range validity {
+		err := CheckShort(elt.code)
+		got := err == nil
+		if got != elt.isShort {
+			t.Errorf("%d. %q validity is %t (err=%v), wanted %t.", i, elt.code, got, err, elt.isShort)
+		}
+	}
+}
+
+func TestCheckFull(t *testing.T) {
+	for i, elt := range validity {
+		err := CheckFull(elt.code)
+		got := err == nil
+		if got != elt.isFull {
+			t.Errorf("%d. %q validity is %t (err=%v), wanted %t.", i, elt.code, got, err, elt.isFull)
+		}
+	}
+}
+
+func TestDecodeValidity(t *testing.T) {
+	for i, elt := range validity {
+		_, err := Decode(elt.code)
+		got := err == nil
+		if got != elt.isFull {
+			t.Errorf("%d. %q validity is %t (err=%v), wanted %t.", i, elt.code, got, err, elt.isValid)
+		}
+	}
+}
+
 func TestEncodeDegrees(t *testing.T) {
 	const allowedErrRate float64 = 0.05
 	var badCodes int

test_data/encoding.csv

@@ -24,6 +24,7 @@
 20.5,2.5,2762500000,1495040000,4,7FG40000+
 -89.9999375,-179.9999375,1562,512,10,22222222+22
 0.5,179.5,2262500000,2945024000,4,6VGX0000+
+0.5,179.5,2262500000,2945024000,3,6VGX0000+
 1,1,2275000000,1482752000,11,6FH32222+222
 ################################################################################
 #

test_data/validityTests.csv

@@ -14,6 +14,8 @@
 8fwc2345+,true,false,true
 8FWCX400+,true,false,true
 84000000+,true,false,true
+C2000000+,true,false,true
+2V000000+,true,false,true
 ################################################################################
 #
 # Valid short codes:
@@ -29,7 +31,9 @@ WC2345+G6g,true,true,false
 #
 ################################################################################
 G+,false,false,false
+G,false,false,false
 +,false,false,false
+45CC+0+,false,false,false
 8FWC2345+G,false,false,false
 8FWC2_45+G6,false,false,false
 8FWC2η45+G6,false,false,false
@@ -40,6 +44,14 @@ WC2300+G6g,false,false,false
 WC2345+G,false,false,false
 WC2300+,false,false,false
 84900000+,false,false,false
+# Cannot start with padding
+049VGJQF+VX7Q,false,false,false
+# Missing separator
+849VGJQFVX7Q,false,false,false
+# Latitude outside range
+F2000000+,true,false,false
+# Longitude outside range
+2W000000+,true,false,false
 ################################################################################
 #
 # Validate that codes at and exceeding 15 digits are still valid when all their