Skip to content

Commit e3d0020

Browse files
committed
ci: rework cmake job in presubmit.yml (#5130)
* remove -O1 and -DNDEBUG on windows * use of CMAKE_CONFIGURATION_TYPES for multi-config generators * explicitly disable GLPK support
1 parent 7caafff commit e3d0020

1 file changed

Lines changed: 11 additions & 9 deletions

File tree

.github/workflows/presubmit.yml

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -54,26 +54,30 @@ jobs:
5454
include:
5555
# Map build to CMake
5656
- build: cpp
57-
cmake: ''
57+
cmake_options: '-DBUILD_DEPS=ON'
5858
- build: java
59-
cmake: '-DBUILD_CXX_SAMPLES=OFF -DBUILD_CXX_EXAMPLES=OFF -DBUILD_JAVA=ON -DSKIP_GPG=ON'
59+
cmake_options: '-DBUILD_CXX_SAMPLES=OFF -DBUILD_CXX_EXAMPLES=OFF -DBUILD_JAVA=ON -DSKIP_GPG=ON'
6060
- build: dotnet
61-
cmake: '-DBUILD_CXX_SAMPLES=OFF -DBUILD_CXX_EXAMPLES=OFF -DBUILD_DOTNET=ON'
61+
cmake_options: '-DBUILD_CXX_SAMPLES=OFF -DBUILD_CXX_EXAMPLES=OFF -DBUILD_DOTNET=ON'
6262
- build: python
63-
cmake: '-DBUILD_CXX_SAMPLES=OFF -DBUILD_CXX_EXAMPLES=OFF -DBUILD_PYTHON=ON'
63+
cmake_options: '-DBUILD_CXX_SAMPLES=OFF -DBUILD_CXX_EXAMPLES=OFF -DBUILD_PYTHON=ON'
6464
# Map os to platform / generator
6565
- os: ubuntu-latest
6666
platform: linux
6767
generator: Ninja
68+
cmake_flags: '-DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS_RELEASE="-O1 -DNDEBUG" -DCMAKE_CXX_FLAGS_RELEASE="-O1 -DNDEBUG"'
6869
- os: macos-15-intel
6970
platform: macos
7071
generator: Xcode
72+
cmake_flags: '-DCMAKE_CONFIGURATION_TYPES="Release" -DCMAKE_C_FLAGS_RELEASE="-O1 -DNDEBUG" -DCMAKE_CXX_FLAGS_RELEASE="-O1 -DNDEBUG"'
7173
- os: macos-latest
7274
platform: macos
7375
generator: Xcode
76+
cmake_flags: '-DCMAKE_CONFIGURATION_TYPES="Release" -DCMAKE_C_FLAGS_RELEASE="-O1 -DNDEBUG" -DCMAKE_CXX_FLAGS_RELEASE="-O1 -DNDEBUG"'
7477
- os: windows-2022
7578
platform: windows
7679
generator: 'Visual Studio 17 2022'
80+
cmake_flags: '-DCMAKE_CONFIGURATION_TYPES="Release"'
7781
runs-on: ${{matrix.os}}
7882
steps:
7983
- uses: actions/checkout@v6
@@ -110,15 +114,13 @@ jobs:
110114
-S.
111115
-Bbuild
112116
-G "${{matrix.generator}}"
113-
-DBUILD_DEPS=ON
114-
-DCMAKE_BUILD_TYPE=Release
115-
-DCMAKE_C_FLAGS_RELEASE="-O1 -DNDEBUG"
116-
-DCMAKE_CXX_FLAGS_RELEASE="-O1 -DNDEBUG"
117+
${{matrix.cmake_options}}
118+
${{matrix.cmake_flags}}
117119
-DCMAKE_INSTALL_PREFIX=install
118120
-DUSE_COINOR=OFF
121+
-DUSE_GLPK=OFF
119122
-DUSE_HIGHS=OFF
120123
-DUSE_SCIP=OFF
121-
${{matrix.cmake}}
122124
- name: Build
123125
run: cmake --build build --config Release -j --target ${{ matrix.generator == 'Ninja' && 'all' || 'ALL_BUILD'}}
124126
- name: Test

0 commit comments

Comments
 (0)