feat: add support for extracting Drupal packages from composer.lock files#950
feat: add support for extracting Drupal packages from composer.lock files#950G-Rath wants to merge 3 commits into
composer.lock files#950Conversation
|
It should be fine to start reviewing this, though I'll keep it as a draft until I've gotten the other OSV related PRs up (this is related to ossf/osv-schema#372) |
0b94590 to
8b065ed
Compare
00355c5 to
c976f4f
Compare
|
Composer actually is somewhat of a free-for-all for security advisories. For example, Drupal core is provided by Packagist.org: https://packagist.org/packages/drupal/core along with other projects which we do not need our custom Composer repository: https://packagist.org/packages/drupal/cms However, we do include advisories for these at Packages.Drupal.org: https://packages.drupal.org/8/security-advisories?packages[]=drupal/core and that is the best source for Drupal security advisories. https://packages.drupal.org/8/packages.json has Composer will show security advisories from any repository for any package. That allows https://packages.drupal.org/8/security-advisories?packages[]=drupal/core to be used by For this, maybe it's best to say the |
That wouldn't be correct since (as far as I can tell) not all By extension, advisories for those packages will have |
That's true, but the authoritative source for security advisories for all Packagist.org projects in the Packagist.org’s advisories for the The |
|
This is no longer needed as we're not going to use a dedicated ecosystem for Drupal |
Drupal packages are those that have been sourced from the Drupal composer repositories (https://packages.drupal.org/8 and https://packages.drupal.org/7), though since Composer does not actually include that information in its lockfile we instead look for
extra.drupalwhich should always be present - this also has the advantage of being compatible with proxies since they should preserve theextradata