test: fail fast on missing VCR cassettes by converting errors to 404#2816
Merged
another-rex merged 1 commit intoMay 20, 2026
Merged
Conversation
another-rex
force-pushed
the
fail-missing-cassette-fast-20260518
branch
from
b15ead4 to
7ab4e88
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2816 +/- ##
==========================================
+ Coverage 79.14% 79.16% +0.01%
==========================================
Files 121 121
Lines 8185 8191 +6
==========================================
+ Hits 6478 6484 +6
Misses 1324 1324
Partials 383 383 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
another-rex
force-pushed
the
fail-missing-cassette-fast-20260518
branch
from
7ab4e88 to
78c17de
Compare
another-rex
changed the title
cuixq
reviewed
May 19, 2026
| if maxNetworkQueryAttempts > 0 { | ||
| // osvdev.Config.MaxRetryAttempts actually controls the maximum number of attempts, | ||
| // where 1 means 1 attempt (0 retries). | ||
| config.MaxRetryAttempts = maxNetworkQueryAttempts |
Contributor
There was a problem hiding this comment.
I am a bit confused about how this config will be propagated through? is the config defined in osv-scalibr?
Collaborator
Author
There was a problem hiding this comment.
It's not needed for scalibr, we have not switched to use the osv-scalibr osvdev enrichers yet.
Collaborator
Author
There was a problem hiding this comment.
But I think I'll rework this a bit, I'm not sure we want to have this as a config in general.
another-rex
force-pushed
the
fail-missing-cassette-fast-20260518
branch
from
78c17de to
9d7170c
Compare
another-rex
changed the title
cuixq
reviewed
May 19, 2026
|
|
||
| func (t *vcrErrorWrappingTransport) RoundTrip(req *http.Request) (*http.Response, error) { | ||
| resp, err := t.wrapper.RoundTrip(req) | ||
| if err != nil && strings.Contains(err.Error(), "requested interaction not found") { |
Contributor
There was a problem hiding this comment.
use errors.Is to check the error?
Contributor
There was a problem hiding this comment.
the error is defined here: https://github.com/dnaeon/go-vcr/blob/v4/pkg/cassette/cassette.go#L50
Collaborator
Author
There was a problem hiding this comment.
Good idea, done.
If a VCR cassette or a specific interaction is missing, the OSV client would previously retry the request 4 times with exponential backoff, causing significant delays in test execution (over 20 seconds). This change wraps the VCR client transport in tests to intercept the "requested interaction not found" error (using errors.Is with cassette.ErrInteractionNotFound) and convert it to a "404 Not Found" response. Since the OSV client does not retry on 404 status codes, this allows tests to fail immediately (~0.02s) on missing cassettes/interactions while still preserving retry behavior for genuine transient network errors. - Implemented vcrErrorWrappingTransport in internal/testcmd/vcr.go - Wrapped the VCR client transport in InsertCassette - Used errors.Is with cassette.ErrInteractionNotFound for robust error matching
another-rex
force-pushed
the
fail-missing-cassette-fast-20260518
branch
from
9d7170c to
f4df75a
Compare
cuixq
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a VCR cassette or a specific interaction is missing, the OSV client would previously retry the request 4 times with exponential backoff, causing significant delays in test execution (over 20 seconds).
This change wraps the VCR client transport in tests to intercept the "requested interaction not found" error (using
errors.Iswithcassette.ErrInteractionNotFoundfor robust matching) and convert it to a "404 Not Found" response. Since the OSV client does not retry on 404 status codes, this allows tests to fail immediately (~0.02s) when a cassette or interaction is missing while still preserving retry behavior for genuine transient network errors.This approach avoids modifying the core
osvscannerlibrary API or adding new CLI flags.vcrErrorWrappingTransportininternal/testcmd/vcr.goInsertCassetteerrors.Iswithcassette.ErrInteractionNotFoundfor robust error matching