Fix some lint

Author: Ly-Joey

go/cmd/gitter/gitter.go

@@ -178,6 +178,7 @@ func fetchRepo(ctx context.Context, url string, forceUpdate bool) error {
 		if os.IsNotExist(err) {
 			deleteLastFetch(url)
 		}
+
 		return fmt.Errorf("failed to read file: %w", err)
 	}
 
@@ -340,9 +341,11 @@ func gitHandler(w http.ResponseWriter, r *http.Request) {
 		logger.Error("Error fetching blob", slog.String("url", url), slog.Any("error", err))
 		if isAuthError(err) {
 			http.Error(w, fmt.Sprintf("Error fetching blob: %v", err), http.StatusForbidden)
+
 			return
 		}
 		http.Error(w, fmt.Sprintf("Error fetching blob: %v", err), http.StatusInternalServerError)
+
 		return
 	}
 
@@ -354,6 +357,7 @@ func gitHandler(w http.ResponseWriter, r *http.Request) {
 	if err != nil {
 		logger.Error("Error archiving blob", slog.String("url", url), slog.Any("error", err))
 		http.Error(w, fmt.Sprintf("Error archiving blob: %v", err), http.StatusInternalServerError)
+
 		return
 	}
 	fileData := fileDataAny.([]byte)
@@ -381,6 +385,7 @@ func cacheHandler(w http.ResponseWriter, r *http.Request) {
 	err := json.NewDecoder(r.Body).Decode(&body)
 	if err != nil {
 		http.Error(w, fmt.Sprintf("Error decoding JSON: %v", err), http.StatusBadRequest)
+
 		return
 	}
 	defer r.Body.Close()
@@ -396,9 +401,11 @@ func cacheHandler(w http.ResponseWriter, r *http.Request) {
 		logger.Error("Error fetching blob", slog.String("url", url), slog.Any("error", err))
 		if isAuthError(err) {
 			http.Error(w, fmt.Sprintf("Error fetching blob: %v", err), http.StatusForbidden)
+
 			return
 		}
 		http.Error(w, fmt.Sprintf("Error fetching blob: %v", err), http.StatusInternalServerError)
+
 		return
 	}
 
@@ -412,6 +419,7 @@ func cacheHandler(w http.ResponseWriter, r *http.Request) {
 	if err != nil {
 		logger.Error("Failed to load repository", slog.String("url", url), slog.Any("error", err))
 		http.Error(w, fmt.Sprintf("Failed to load repository: %v", err), http.StatusInternalServerError)
+
 		return
 	}
 
@@ -431,6 +439,7 @@ func affectedCommitsHandler(w http.ResponseWriter, r *http.Request) {
 	err := json.NewDecoder(r.Body).Decode(&body)
 	if err != nil {
 		http.Error(w, fmt.Sprintf("Error decoding JSON: %v", err), http.StatusBadRequest)
+
 		return
 	}
 	defer r.Body.Close()
@@ -468,6 +477,7 @@ func affectedCommitsHandler(w http.ResponseWriter, r *http.Request) {
 	// Limit and fixed/last_affected shouldn't exist in the same request as it doesn't make sense
 	if (len(fixed) > 0 || len(lastAffected) > 0) && len(limit) > 0 {
 		http.Error(w, "Limit and fixed/last_affected shouldn't exist in the same request", http.StatusBadRequest)
+
 		return
 	}
 
@@ -479,9 +489,11 @@ func affectedCommitsHandler(w http.ResponseWriter, r *http.Request) {
 		logger.Error("Error fetching blob", slog.String("url", url), slog.Any("error", err))
 		if isAuthError(err) {
 			http.Error(w, fmt.Sprintf("Error fetching blob: %v", err), http.StatusForbidden)
+
 			return
 		}
 		http.Error(w, fmt.Sprintf("Error fetching blob: %v", err), http.StatusInternalServerError)
+
 		return
 	}
 
@@ -495,6 +507,7 @@ func affectedCommitsHandler(w http.ResponseWriter, r *http.Request) {
 	if err != nil {
 		logger.Error("Failed to load repository", slog.String("url", url), slog.Any("error", err))
 		http.Error(w, fmt.Sprintf("Failed to load repository: %v", err), http.StatusInternalServerError)
+
 		return
 	}
 	repo := repoAny.(*Repository)
@@ -509,6 +522,7 @@ func affectedCommitsHandler(w http.ResponseWriter, r *http.Request) {
 	if err != nil {
 		logger.Error("Error processing affected commits", slog.String("url", url), slog.Any("error", err))
 		http.Error(w, fmt.Sprintf("Error processing affected commits: %v", err), http.StatusInternalServerError)
+
 		return
 	}
 
@@ -517,6 +531,7 @@ func affectedCommitsHandler(w http.ResponseWriter, r *http.Request) {
 	if err := json.NewEncoder(w).Encode(affectedCommits); err != nil {
 		logger.Error("Error encoding affected commits", slog.String("url", url), slog.Any("error", err))
 		http.Error(w, fmt.Sprintf("Error encoding affected commits: %v", err), http.StatusInternalServerError)
+
 		return
 	}
 	logger.Info("Request completed successfully: /affected-commits", slog.String("url", url), slog.Duration("duration", time.Since(start)))

go/cmd/gitter/gitter_test.go

@@ -82,7 +82,7 @@ func TestGitHandler_InvalidURL(t *testing.T) {
 // Override global variables for test
 // Note: In a real app we might want to dependency inject these,
 // but for this simple script we modify package globals.
-func setupTest(t *testing.T) string {
+func setupTest(t *testing.T) {
 	t.Helper()
 	tmpDir := t.TempDir()
 
@@ -100,8 +100,6 @@ func setupTest(t *testing.T) string {
 		saveTimer.Stop()
 		saveTimer = nil
 	}
-
-	return tmpDir
 }
 
 func TestGitHandler_Integration(t *testing.T) {

go/cmd/gitter/repository.go

@@ -67,10 +67,14 @@ func LoadRepository(ctx context.Context, repoPath string) (*Repository, error) {
 	// Load cache pb file of the repo if exist
 	if c, err := loadRepositoryCache(cachePath); err == nil {
 		cache = c
-		logger.Info("Loaded repository cache", slog.Int("commits", len(cache.Commits)))
+		logger.Info("Loaded repository cache", slog.Int("commits", len(cache.GetCommits())))
 	} else {
-		// It's fine if cache doesn't exist
-		logger.Info("No repository cache found or failed to load", slog.Any("err", err))
+		if err == os.ErrNotExist {
+			// It's fine if cache doesn't exist, log it just in case
+			logger.Info("No repository cache found")
+		} else {
+			return nil, fmt.Errorf("failed to load repository cache: %w", err)
+		}
 	}
 
 	// Commit graph is built from scratch every time
@@ -247,6 +251,7 @@ func (r *Repository) calculatePatchIDs(ctx context.Context, commits []SHA1) erro
 	}
 
 	logger.Info("Patch ID calculation completed", slog.Int("commits", len(commits)), slog.Duration("duration", time.Since(start)))
+
 	return nil
 }
 

go/cmd/gitter/repository_test.go

@@ -20,13 +20,15 @@ func decodeSHA1(s string) SHA1 {
 		panic(err)
 	}
 	copy(hash[:], b)
+
 	return hash
 }
 
 // Helper to encode SHA1 into string (leading 0's removed)
 func encodeSHA1(hash SHA1) string {
 	// Remove padding zeros for a cleaner results
 	str := hex.EncodeToString(hash[:])
+
 	return strings.TrimLeft(str, "0")
 }