fixing missing outcomes

jess-lowe · jess-lowe · commit 8f332974bd8c · 2026-03-02T00:49:05.000Z
diff --git a/vulnfeeds/conversion/nvd/converter.go b/vulnfeeds/conversion/nvd/converter.go
@@ -52,6 +52,7 @@ func CVEToOSV(cve models.NVDCVE, repos []string, cache *git.RepoTagsCache, direc
 
 	// If there are no repos, there are no commits from the refs either
 	if len(cpeRanges) == 0 && len(repos) == 0 {
+		metrics.SetOutcome(models.NoRepos)
 		outputFiles(v, directory, maybeVendorName, maybeProductName, metrics, rejectFailed, outputMetrics)
 		return models.NoRepos
 	}
diff --git a/vulnfeeds/models/metrics.go b/vulnfeeds/models/metrics.go
@@ -61,7 +61,7 @@ func (m *ConversionMetrics) AddNote(format string, a ...any) {
 
 // SetOutcome sets the outcome of the conversion only if it's not already set, or has become successful.
 func (m *ConversionMetrics) SetOutcome(outcome ConversionOutcome) {
-	if m.Outcome != ConversionUnknown || outcome != Successful {
+	if m.Outcome != ConversionUnknown || m.Outcome == Successful {
 		return
 	}
 	m.Outcome = outcome

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ func CVEToOSV(cve models.NVDCVE, repos []string, cache *git.RepoTagsCache, direc`
`52`	`52`
`53`	`53`	`// If there are no repos, there are no commits from the refs either`
`54`	`54`	`if len(cpeRanges) == 0 && len(repos) == 0 {`
	`55`	`+ metrics.SetOutcome(models.NoRepos)`
`55`	`56`	`outputFiles(v, directory, maybeVendorName, maybeProductName, metrics, rejectFailed, outputMetrics)`
`56`	`57`	`return models.NoRepos`
`57`	`58`	`}`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ func (m *ConversionMetrics) AddNote(format string, a ...any) {`
`61`	`61`
`62`	`62`	`// SetOutcome sets the outcome of the conversion only if it's not already set, or has become successful.`
`63`	`63`	`func (m *ConversionMetrics) SetOutcome(outcome ConversionOutcome) {`
`64`		`- if m.Outcome != ConversionUnknown \|\| outcome != Successful {`
	`64`	`+ if m.Outcome != ConversionUnknown \|\| m.Outcome == Successful {`
`65`	`65`	`return`
`66`	`66`	`}`
`67`	`67`	`m.Outcome = outcome`