infra: set GOMEMLIMIT for gitter service#4847
Conversation
This change adds the GOMEMLIMIT environment variable to the gitter service deployment configuration, setting it to 200GiB. This is intended to limit memory usage and trigger more aggressive garbage collection when approaching the pod's memory limit of 250G. The value 200GiB (approx 214.7GB) was chosen to provide a safety buffer below the 250G limit while maximizing available memory for cache and operations. Co-authored-by: another-rex <106129829+another-rex@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change adds the GOMEMLIMIT environment variable to the gitter service deployment configuration, setting it to 200GiB. This is intended to limit memory usage and trigger more aggressive garbage collection when approaching the pod's memory limit of 250G. The value 200GiB (approx 214.7GB) was chosen to provide a safety buffer below the 250G limit while maximizing available memory for cache and operations. Co-authored-by: another-rex <106129829+another-rex@users.noreply.github.com>
michaelkedar
left a comment
michaelkedar
left a comment
There was a problem hiding this comment.
How much memory should we be allocating to the non-go part.
Currently you've got ~40GB
|
Well I looked at htop and it says it's mostly golang using the memory... |
2 participants
Added
GOMEMLIMIT=200GiBtodeployment/clouddeploy/gke-workers/base/gitter.yaml.This ensures the Go runtime is aware of the memory limit and performs garbage collection more aggressively before reaching the container's hard limit, preventing OOM kills.
Verified the syntax and value format (GiB suffix required by Go runtime).
PR created automatically by Jules for task 17608800381604387364 started by @another-rex