feat: LOG_LEVEL env var in go#4852
Merged
Hidden character warning
The head ref may contain hidden characters: "\ud83e\udeb5\ud83c\udf9a"
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
tobyhawker
approved these changes
Feb 19, 2026
tobyhawker
left a comment
tobyhawker
left a comment
Contributor
There was a problem hiding this comment.
Just to be clear, I think the name is fine, it's unambiguous.
| level = slog.LevelWarn | ||
| case "error": | ||
| level = slog.LevelError | ||
| } |
Contributor
There was a problem hiding this comment.
Should there be a default for e.g. a typo
Member
Author
There was a problem hiding this comment.
It's set to info before the switch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discussions were had