fix(vulnfeeds): Cache patch#4876
Merged
Merged
Conversation
Sometimes vendor product combinations in the VPRepoCache are given "successful" repos in its cache that are unrelated to the project. I believe this is to do with how larger projects that are affected by the vuln (like Debian/RH etc) are also added to the record. With the cache, if a record earlier on resolves a repo, but saves it to a Vendor Product that is unrelated, this might cause a bad cache entry.
another-rex
previously approved these changes
Feb 24, 2026
another-rex
approved these changes
Feb 24, 2026
tymzd
pushed a commit
to tymzd/osv.dev
that referenced
this pull request
Apr 13, 2026
Sometimes vendor product combinations in the VPRepoCache are given "successful" repos in its cache that are unrelated to the project. I believe this is to do with how larger projects that are affected by the vuln (like Debian/RH etc) are also added to the record. With the cache, if a record earlier on resolves a repo, but saves it to a Vendor Product that is unrelated, this might cause a bad cache entry. This unfortunately might slow things down but its better than bad misses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes vendor product combinations in the VPRepoCache are given "successful" repos in its cache that are unrelated to the project. I believe this is to do with how larger projects that are affected by the vuln (like Debian/RH etc) are also added to the record.
With the cache, if a record earlier on resolves a repo, but saves it to a Vendor Product that is unrelated, this might cause a bad cache entry.
This unfortunately might slow things down but its better than bad misses.