feat: upgrade lipgloss & copy logger package back over to vulnfeeds#4966
Merged
Hidden character warning
The head ref may contain hidden characters: "\ud83d\udc84\ud83e\udeb5"
Conversation
cuixq
pushed a commit
that referenced
this pull request
Mar 4, 2026
My tests in #4966 were failing because `protojson` decided it wanted to add two spaces between the keys and values in its output. Run the `protojson` output through the `json.Indent` to format it consistently. That said, does the formatting of the output actually matter here? Should we instead rewrite the tests to do a semantic comparison instead of a string comparison?
jess-lowe
approved these changes
Mar 5, 2026
tymzd
pushed a commit
to tymzd/osv.dev
that referenced
this pull request
Apr 13, 2026
My tests in google#4966 were failing because `protojson` decided it wanted to add two spaces between the keys and values in its output. Run the `protojson` output through the `json.Indent` to format it consistently. That said, does the formatting of the output actually matter here? Should we instead rewrite the tests to do a semantic comparison instead of a string comparison?
tymzd
pushed a commit
to tymzd/osv.dev
that referenced
this pull request
Apr 13, 2026
…oogle#4966) upgrading lipgloss to v2, fixing issues with google#4895 Also copied over the changes to the logger made in `go/` back over to `vulnfeeds/`, which means error logs would start showing up in error reporting. (I didn't instrument traces/spans, because that's too involved for me)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrading lipgloss to v2, fixing issues with #4895
Also copied over the changes to the logger made in
go/back over tovulnfeeds/, which means error logs would start showing up in error reporting.(I didn't instrument traces/spans, because that's too involved for me)