Update pthreadpool_thread_(create|join) function signatures.#73
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_817671083
branch
2 times, most recently
from
3041510 to
72e015c
Compare
copybara-service
Bot
changed the title
pthreadpool_thread_create function signature.pthreadpool_thread_(create|join) function signatures.
copybara-service
Bot
force-pushed
the
test_817671083
branch
from
72e015c to
e9d67b1
Compare
- `thrd_create` expects a thread function that returns an `int`. - `pthread_create` expects a thread function that returns a `void*`. Introduce the `pthreadpool_thread_return_t` type definition that maps to the correct type depending on the implementation that is used. PiperOrigin-RevId: 817810757
copybara-service
Bot
force-pushed
the
test_817671083
branch
from
e9d67b1 to
e8c7ec2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
pthreadpool_thread_(create|join)function signatures.thrd_createexpects a thread function that returns anint.pthread_createexpects a thread function that returns avoid*.Introduce the
pthreadpool_thread_return_ttype definition that maps to thecorrect type depending on the implementation that is used.