Skip to content

Internal Code Change #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Internal Code Change #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pthreads.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ static void signal_num_recruited_threads(pthreadpool_t threadpool) {
static void signal_num_active_threads(pthreadpool_t threadpool,
uint32_t max_num_waiting) {
#if PTHREADPOOL_USE_FUTEX
const uint32_t num_waiting_threads =
[[maybe_unused]] const uint32_t num_waiting_threads =
pthreadpool_load_consume_uint32_t(&threadpool->num_waiting_threads);
if (num_waiting_threads > max_num_waiting) {
futex_wake_n((pthreadpool_atomic_uint32_t*)&threadpool->num_active_threads,
Expand All @@ -337,7 +337,7 @@ static void signal_num_active_threads(pthreadpool_t threadpool,
}

static void signal_work_is_done(pthreadpool_t threadpool) {
uint32_t prev_value = pthreadpool_exchange_acquire_release_uint32_t(
[[maybe_unused]] uint32_t prev_value = pthreadpool_exchange_acquire_release_uint32_t(
&threadpool->work_is_done, 1);
assert(prev_value == 0);
#if PTHREADPOOL_USE_FUTEX
Expand Down Expand Up @@ -670,7 +670,7 @@ PTHREADPOOL_INTERNAL void pthreadpool_parallelize(
pthreadpool_fence_acquire();

/* Make sure the threadpool is idle or done. */
const int32_t num_active_threads =
[[maybe_unused]] const int32_t num_active_threads =
pthreadpool_load_consume_int32_t(&threadpool->num_active_threads);
assert(num_active_threads == 0 ||
num_active_threads == PTHREADPOOL_NUM_ACTIVE_THREADS_DONE);
Expand Down
Loading