Fix MLX implementation of LocalDotProductSelfAttention that previously overwrote block_size#16
Open
lancelotblanchard wants to merge 1 commit into
Open
Fix MLX implementation of LocalDotProductSelfAttention that previously overwrote block_size#16lancelotblanchard wants to merge 1 commit into
lancelotblanchard wants to merge 1 commit into
Conversation
…y overwrote block_size, and add tests
Collaborator
|
Great catch -- this is an unfortunate name clash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current MLX implementation of
LocalDotProductSelfAttentiondoes:, which overwrites the
block_sizeproperty of the class and breaks inference usingstep, which needsblock_size=1. Instead, the JAX implementation does not overwrite the property. This PR fixes the MLX implementation to match the JAX one.Additionally, this PR adds corresponding attention tests (
self.assertEqual(layer.block_size, 1)) for the step function, and modifiesDefaultSteppableto make sure properties are read from base classbackend_sl.types.Steppableand notDefaultTestLayer.