syz-ci, pkg/updater: validate manager configs on new syzkaller builds#7166
Open
anishesg wants to merge 1 commit into
Open
syz-ci, pkg/updater: validate manager configs on new syzkaller builds#7166anishesg wants to merge 1 commit into
anishesg wants to merge 1 commit into
Conversation
When syscalls are renamed between syzkaller revisions, manager configs that reference the old names Signed-off-by: anish k <ak8686@princeton.edu>
dvyukov
reviewed
May 6, 2026
| // revision, in particular that enable_syscalls and disable_syscalls only reference syscalls that | ||
| // exist in the current build. This is run as part of the syzkaller build process so that syscall | ||
| // renames are caught as build errors rather than runtime failures during patch testing. | ||
| func checkManagerConfigs(managers []*ManagerConfig) error { |
Collaborator
There was a problem hiding this comment.
The problem is that this still runs with the old version of the code, not the new code, so it won't detect problems.
It needs to run with the new version of the code.
| if cfg == nil { | ||
| continue | ||
| } | ||
| if _, err := mgrconfig.ParseEnabledSyscalls(cfg.Target, cfg.EnabledSyscalls, |
Collaborator
There was a problem hiding this comment.
Can we call full config parsing here? It should check both enabled syscalls, but also all other fields.
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When syscalls are renamed between syzkaller revisions, manager configs that reference the old names
in
enable_syscallscause#syz testto fail immediately with "unknown enabled syscall" before anyVM is started. The failure comes from
mgrconfig.Completeininstance.Test(), which validatessyscall names against the current process's compiled-in
prog.Target—even though the old nameswould be valid for the target
SyzkallerCommitbeing tested.The fix adds a
CheckConfigscallback topkg/updater.Configthat is invoked after a successfulsyzkaller build in
Updater.build(). Insyz-ci, this callback callscheckManagerConfigs, whichruns
mgrconfig.ParseEnabledSyscallsfor every manager config against the current revision'ssyscall table. If a syscall name was renamed in the new revision, the build is rejected before it
is deployed, and
uploadSyzkallerBuildErrorreports the failure to the dashboard. This turns asilent runtime failure into a proactive build-time error so CI operators know to update manager
configs before the new revision goes live.
Fixes #7025