Fix: Redirect auto-sample logging to stderr#272
Merged
Conversation
The auto-sample logging output in runner.ts was previously directed to stdout. This change redirects the logging output to stderr.
aomarks
approved these changes
Jul 3, 2025
Member
aomarks
left a comment
aomarks
left a comment
There was a problem hiding this comment.
Makes sense to me; it will allow distinguishing the result output from the status output more easily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auto-sample logging output in runner.ts was previously directed to stdout. This change redirects the logging output to stderr.
We are capturing stdout in order to change the formatting a little bit, but we would still like to see the auto-sampling output.
I don't know how to test this out though.