Fix a few compilation warnings and metric asan issues

PiperOrigin-RevId: 940906248
Change-Id: Icccc528ae1e169a8bb24eb97e7d2e7f191eb4a15

Author: laramiel

.bazelrc

@@ -75,6 +75,17 @@ build:msvc --per_file_copt=grpc/.*\\.cc$@/wd4244
 build:msvc --host_per_file_copt=grpc/.*\\.cc$@/wd4244
 build:msvc --per_file_copt=external/xds/.*\\.cc$@/wd4244
 build:msvc --host_per_file_copt=external/xds/.*\\.cc$@/wd4244
+build:msvc --per_file_copt=grpc/.*$@/wd4715
+build:msvc --host_per_file_copt=grpc/.*$@/wd4715
+
+# Silence macro redefinition warnings from AWS SDK
+build:msvc --per_file_copt=external/aws_c_.*$@/wd4005
+build:msvc --host_per_file_copt=external/aws_c_.*$@/wd4005
+
+# Silence not all control paths return a value warnings from protobuf
+build:msvc --per_file_copt=external/com_google_protobuf/.*$@/wd4715
+build:msvc --host_per_file_copt=external/com_google_protobuf/.*$@/wd4715
+
 
 # ----------------------------------------
 # Disable warnings

tensorstore/internal/metrics/BUILD

@@ -136,6 +136,7 @@ tensorstore_cc_library(
     deps = [
         ":domain_field",
         "@abseil-cpp//absl/base:core_headers",
+        "@abseil-cpp//absl/base:dynamic_annotations",
         "@abseil-cpp//absl/container:node_hash_map",
         "@abseil-cpp//absl/debugging:leak_check",
         "@abseil-cpp//absl/functional:function_ref",

tensorstore/internal/metrics/metric_impl.h

@@ -28,6 +28,7 @@
 #include <type_traits>
 #include <utility>
 
+#include "absl/base/dynamic_annotations.h"
 #include "absl/base/optimization.h"
 #include "absl/container/node_hash_map.h"
 #include "absl/debugging/leak_check.h"
@@ -88,6 +89,7 @@ size_t MetricThreadCounter();
 template <typename T>
 T* LazyInit(std::atomic<T*>& ptr) {
   T* p = ptr.load(std::memory_order_acquire);
+  ABSL_ANNOTATE_MEMORY_IS_INITIALIZED(&p, sizeof(p));
   if (ABSL_PREDICT_FALSE(!p)) {
     auto* candidate = absl::IgnoreLeak(new T());
     T* expected = nullptr;
@@ -326,8 +328,7 @@ class AbstractMetric {
   using field_values_type = typename Key::tuple_type;
   using value_type = typename Cell::value_type;
 
-  constexpr AbstractMetric() : state_(nullptr) {}
-
+  constexpr AbstractMetric() = default;
   ~AbstractMetric() {
     // NOTE: State* should be "eternal", so we just leak it.
   }
@@ -384,14 +385,14 @@ class AbstractMetric {
  private:
   State* GetState() const { return LazyInit(state_); }
 
-  mutable std::atomic<State*> state_;
+  mutable std::atomic<State*> state_{nullptr};
 };
 
 // Lock-free Specialization for no fields using a sharded counter.
 template <typename Cell>
 class AbstractMetric<Cell, true> {
  public:
-  static constexpr bool kNumThreads = 4;
+  static constexpr size_t kNumThreads = 4;
   using field_values_type = std::tuple<>;
   using value_type = typename Cell::value_type;
 
@@ -432,7 +433,7 @@ class AbstractMetric<Cell, true> {
 template <typename Cell, typename Enable = void>
 class CellStorage {
  public:
-  constexpr CellStorage() : value_() {}
+  constexpr CellStorage() = default;
   ~CellStorage() = default;
 
   Cell* Get() const { return &value_; }
@@ -447,7 +448,7 @@ template <typename Cell>
 class CellStorage<Cell,
                   std::enable_if_t<!std::is_trivially_destructible_v<Cell>>> {
  public:
-  constexpr CellStorage() : ptr_(nullptr) {}
+  constexpr CellStorage() = default;
   ~CellStorage() {
     // NOTE: Cell* should be "eternal", so we just leak it.
   }
@@ -462,7 +463,7 @@ class CellStorage<Cell,
   }
 
  private:
-  mutable std::atomic<Cell*> ptr_;
+  mutable std::atomic<Cell*> ptr_{nullptr};
 };
 
 // Lock-free Specialization for no fields.

tensorstore/util/span.h

@@ -115,8 +115,8 @@ struct SpanTypeHelper<T, std::void_t<internal_span::ContainerElementType<T>>> {
   constexpr static ptrdiff_t extent = dynamic_extent;
 };
 
-constexpr inline ptrdiff_t SubspanExtent(ptrdiff_t extent, ptrdiff_t offset,
-                                         ptrdiff_t count) {
+constexpr ptrdiff_t SubspanExtent(ptrdiff_t extent, ptrdiff_t offset,
+                                  ptrdiff_t count) {
   return count == dynamic_extent && extent == dynamic_extent ? dynamic_extent
          : count == dynamic_extent                           ? extent - offset
                                                              : count;
@@ -404,7 +404,7 @@ class span {
     if (ABSL_PREDICT_TRUE(i < size() && i >= 0)) {
       return *(data() + i);
     }
-    ABSL_LOG(FATAL) << "span.at(" << i << (i >= 0 ? ") >= size()" : ") i < 0");
+    AtFatal(i);
   }
 
   /// Returns a reference to the first element.
@@ -440,6 +440,10 @@ class span {
   std::conditional_t<Extent == dynamic_extent, ptrdiff_t,
                      std::integral_constant<ptrdiff_t, Extent>>
       size_;
+
+  [[noreturn]] void AtFatal(ptrdiff_t i) const {
+    ABSL_LOG(FATAL) << "span.at(" << i << (i >= 0 ? ") >= size()" : ") i < 0");
+  }
 };
 
 template <typename T>