Skip to content

fix: allow unencrypted PEM#3885

Merged
AlCutter merged 1 commit into
google:masterfrom
securesign:allow-unencrypted-pem
May 20, 2026
Merged

fix: allow unencrypted PEM#3885
AlCutter merged 1 commit into
google:masterfrom
securesign:allow-unencrypted-pem

Conversation

@JasonPowr
Copy link
Copy Markdown
Contributor

Allow ReadPrivateKeyFile and FromProto (via PEMKeyFile) to accept unencrypted PEM private key files by removing the empty password guard. UnmarshalPrivateKey already handled both cases correctly.

Checklist

@JasonPowr JasonPowr requested a review from a team as a code owner May 15, 2026 09:18
@JasonPowr JasonPowr requested a review from AlCutter May 15, 2026 09:18
@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 15, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@AlCutter
Copy link
Copy Markdown
Member

Hi @JasonPowr, thanks for the PR.

Could you drop the merge commit and just rebase the first commit onto an up-to-date master?

@JasonPowr JasonPowr force-pushed the allow-unencrypted-pem branch from 035cc57 to 63c9eb1 Compare May 20, 2026 11:52
@JasonPowr
Copy link
Copy Markdown
Contributor Author

@AlCutter Sure done :)

@AlCutter
Copy link
Copy Markdown
Member

/gcbrun

@AlCutter AlCutter merged commit a2a78a8 into google:master May 20, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants