Skip to content

Enable host trace streaming by adding Consume/Serialize API #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable host trace streaming by adding Consume/Serialize API #3523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tsl/profiler/lib/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ cc_library(
]),
deps = [
"//tsl/profiler/protobuf:xplane_proto_cc",
"@xla//xla/tsl/platform:status",
"@com_google_absl//absl/status",
],
)

Expand Down
16 changes: 15 additions & 1 deletion tsl/profiler/lib/profiler_interface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ limitations under the License.
#ifndef TENSORFLOW_TSL_PROFILER_LIB_PROFILER_INTERFACE_H_
#define TENSORFLOW_TSL_PROFILER_LIB_PROFILER_INTERFACE_H_

#include "xla/tsl/platform/status.h"
#include <cstddef>

#include "absl/status/status.h"
#include "tsl/profiler/protobuf/xplane.pb.h"

namespace tsl {
Expand All @@ -41,6 +43,18 @@ class ProfilerInterface {

// Saves collected profile data into XSpace.
virtual absl::Status CollectData(tensorflow::profiler::XSpace* space) = 0;

// Pulls collected profile data into arbitrary raw memory.
// Size refers to the amount of data memory `ptr` points to.
virtual absl::Status Consume(void* ptr, size_t size) {
return absl::UnimplementedError("Consume not implemented");
}

// Serializes collected profile data into a wire-transferrable format.
virtual absl::Status Serialize(void* ptr, size_t size, void* output,
size_t output_size) {
return absl::UnimplementedError("Serialize not implemented");
}
};

} // namespace profiler
Expand Down
Loading