Fix: Hardening DefaultConnectionFactory against Blind SSRF via redirects#160
Open
ngaturjiwo77-hue wants to merge 1 commit into
Open
Fix: Hardening DefaultConnectionFactory against Blind SSRF via redirects#160ngaturjiwo77-hue wants to merge 1 commit into
ngaturjiwo77-hue wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ngaturjiwo77-hue
force-pushed
the
master
branch
from
23aaf8d to
fcb115c
Compare
Author
|
@google-cla check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables automatic redirect following in HttpURLConnection. As identified in the Tsunami architecture, allowing automatic redirects can be weaponized to target internal metadata services (169.254.169.254) or local gRPC language servers (127.0.0.1) exposed via RemoteVulnDetectorLoadingModule.