Skip to content

Commit b91e955

Browse files
authored
Add missing glslc argument "--target-env=vulkan1.1" (#53)
All the benchmarks use this expect compute and matmul, which fail to compile, complamning that SPIR-V 1.3 is required. If we dont' specity the target we use vulkan-1.0 which default to SPIR-V 1.0. glslc -h ... --target-env=<environment> Set the target client environment, and the semantics of warnings and errors. An optional suffix can specify the client version. Values are: vulkan1.0 # The default vulkan1.1 vulkan1.2 vulkan1.3 vulkan1.4 vulkan # Same as vulkan1.0 opengl4.5 opengl # Same as opengl4.5 --target-spv=<spirv-version> Set the SPIR-V version to be used for the generated SPIR-V module. The default is the highest version of SPIR-V required to be supported for the target environment. For example, default for vulkan1.0 is spv1.0, and the default for vulkan1.1 is spv1.3, the default for vulkan1.2 is spv1.5, the default for vulkan1.3 is spv1.6, the default for vulkan1.4 is spv1.6. Values are: spv1.0, spv1.1, spv1.2, spv1.3, spv1.4, spv1.5, spv1.6
1 parent 2e4c8e4 commit b91e955

2 files changed

Lines changed: 22 additions & 0 deletions

File tree

benchmarks/compute/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ uvkc_glsl_shader_permutation(
1919
"mad_throughput.glsl"
2020
PERMUTATION
2121
"TYPE=[f16vec4|vec4]"
22+
GLSLC_ARGS
23+
"--target-env=vulkan1.1"
2224
)
2325

2426
uvkc_cc_binary(

benchmarks/matmul/CMakeLists.txt

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ uvkc_glsl_shader_permutation(
2828
"TEXTURE=[1|0]"
2929
"WG_X=32"
3030
"WG_Y=2"
31+
GLSLC_ARGS
32+
"--target-env=vulkan1.1"
3133
)
3234

3335
uvkc_glsl_shader_permutation(
@@ -41,6 +43,8 @@ uvkc_glsl_shader_permutation(
4143
"TILE_K=[4|8]"
4244
"WG_X=32"
4345
"WG_Y=2"
46+
GLSLC_ARGS
47+
"--target-env=vulkan1.1"
4448
)
4549

4650
uvkc_glsl_shader_permutation(
@@ -54,6 +58,8 @@ uvkc_glsl_shader_permutation(
5458
"TILE_K=[4|8]"
5559
"WG_X=32"
5660
"WG_Y=2"
61+
GLSLC_ARGS
62+
"--target-env=vulkan1.1"
5763
)
5864

5965
uvkc_glsl_shader_permutation(
@@ -67,6 +73,8 @@ uvkc_glsl_shader_permutation(
6773
"TILE_K=[4|8]"
6874
"WG_X=32"
6975
"WG_Y=2"
76+
GLSLC_ARGS
77+
"--target-env=vulkan1.1"
7078
)
7179

7280
uvkc_glsl_shader_permutation(
@@ -80,6 +88,8 @@ uvkc_glsl_shader_permutation(
8088
"TILE_K=[4|8]"
8189
"WG_X=32"
8290
"WG_Y=2"
91+
GLSLC_ARGS
92+
"--target-env=vulkan1.1"
8393
)
8494

8595
uvkc_cc_binary(
@@ -116,6 +126,8 @@ uvkc_glsl_shader_permutation(
116126
"TEXTURE=[1|0]"
117127
"WG_X=8"
118128
"WG_Y=2"
129+
GLSLC_ARGS
130+
"--target-env=vulkan1.1"
119131
)
120132

121133
uvkc_glsl_shader_permutation(
@@ -129,6 +141,8 @@ uvkc_glsl_shader_permutation(
129141
"TILE_K=[4|8]"
130142
"WG_X=16"
131143
"WG_Y=1"
144+
GLSLC_ARGS
145+
"--target-env=vulkan1.1"
132146
)
133147

134148
uvkc_glsl_shader_permutation(
@@ -142,6 +156,8 @@ uvkc_glsl_shader_permutation(
142156
"TILE_K=[4|8]"
143157
"WG_X=16"
144158
"WG_Y=1"
159+
GLSLC_ARGS
160+
"--target-env=vulkan1.1"
145161
)
146162

147163
uvkc_glsl_shader_permutation(
@@ -155,6 +171,8 @@ uvkc_glsl_shader_permutation(
155171
"TILE_K=[4|8]"
156172
"WG_X=16"
157173
"WG_Y=1"
174+
GLSLC_ARGS
175+
"--target-env=vulkan1.1"
158176
)
159177

160178
uvkc_glsl_shader_permutation(
@@ -168,6 +186,8 @@ uvkc_glsl_shader_permutation(
168186
"TILE_K=[4|8]"
169187
"WG_X=16"
170188
"WG_Y=1"
189+
GLSLC_ARGS
190+
"--target-env=vulkan1.1"
171191
)
172192

173193
uvkc_cc_binary(

0 commit comments

Comments
 (0)