feat: add prebuilt native asset hook support#275
Conversation
|
|
||
| These binaries should be generated by maintainer-triggered CI from merged | ||
| source, then committed by a maintainer. They should not be accepted from | ||
| user-authored PRs. |
There was a problem hiding this comment.
I just want to highlight alternative options, in no particular order.
- (A) We build
prebuilt/as part of the automated publishing job, they are always build github actions and published inside the package to pub.dev - (B) We build
prebuilt/and upload as artifacts on the github release we create when we create a new version, the hook will then have to download these from github releases. - (C) We build
prebuilt/and then commit them to git.
(C) has the downside that repository size will increase significantly over time, especially if we add more architectures/platforms.
(A) has the downside that download size of users will increase, but not that much. pub.dev will refuse packages larger than 100mb or 200mb (I don't recall the exact limits), but we'll probably be okay unless we add many architectures.
If we can build the artifacts in github CI, then perhaps (A) is attractive? We also avoid maintainer churn and avoid having to store binary artifacts in github.
|
@HamdaanAliQuatil I filed #325, based on |
3 participants
No description provided.