Improve interval set reduction for variadic operations.#4237
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Improve interval set reduction for variadic operations.#4237copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_913911845
branch
2 times, most recently
from
4ac23dd to
b7b342c
Compare
The interval set reduction for variadic operations is now performed dynamically based on the total number of combinations of intervals across all operands. A new function, `ReduceIntervalFragmentationForOp`, iteratively merges intervals in the input sets, prioritizing merges that result in the smallest loss of precision (i.e., those with the smallest gaps between intervals). This ensures that the number of operations remains below a defined threshold, preventing exponential blow-up, while still maintaining as much precision as possible. Fixes: #4233 PiperOrigin-RevId: 913911845
copybara-service
Bot
force-pushed
the
test_913911845
branch
from
b7b342c to
c0eea61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve interval set reduction for variadic operations.
The interval set reduction for variadic operations is now performed dynamically based on the total number of combinations of intervals across all operands. A new function,
ReduceIntervalFragmentationForOp, iteratively merges intervals in the input sets, prioritizing merges that result in the smallest loss of precision (i.e., those with the smallest gaps between intervals). This ensures that the number of operations remains below a defined threshold, preventing exponential blow-up, while still maintaining as much precision as possible.Fixes: #4233