Sim Hand Pose Migration to Angular Representation#323
Merged
Conversation
dli7319
approved these changes
Jun 1, 2026
| updateJsonViews(); | ||
| requestAnimationFrame(syncDisplayedPose); | ||
| }; | ||
| syncDisplayedPose(); |
Collaborator
There was a problem hiding this comment.
Can we call this in update() instead?
Contributor
Author
There was a problem hiding this comment.
just moved this out into its own xb script + update
ruofeidu
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing some of the issues identified from the migration to FK angles in sim hands.
Updated the following in the SDK:
Updated
demos/sim_hand_posesto:The migration to angles makes a small but nice change to the visualizations where now changing poses in the sim looks way more realistic since we LERP over angles. You can see this in the demo video below. First 9 seconds are the old representation rest of the video is the new representation.
https://youtu.be/ihSz8tLXd1U