Skip to content

fix(uiblocks): prevent leading spaces on wrapped lines in TextWithEmoji#330

Merged
dli7319 merged 1 commit into
google:mainfrom
dli7319:textwithemoji
Jun 2, 2026
Merged

fix(uiblocks): prevent leading spaces on wrapped lines in TextWithEmoji#330
dli7319 merged 1 commit into
google:mainfrom
dli7319:textwithemoji

Conversation

@dli7319
Copy link
Copy Markdown
Collaborator

@dli7319 dli7319 commented Jun 2, 2026

  • Automatically groups space segments with their preceding words by appending spaces directly to the word's Text value.
  • Groups space segments with their preceding emojis by applying calculated spaces as marginRight on the emoji's Image component.
  • Retains explicit spaces following newlines or at the start of text as standalone space segments.
  • Updates and expands Vitest suite with comprehensive space-grouping layout assertions.
image

- Automatically groups space segments with their preceding words by appending spaces directly to the word's Text value.
- Groups space segments with their preceding emojis by applying calculated spaces as marginRight on the emoji's Image component.
- Retains explicit spaces following newlines or at the start of text as standalone space segments.
- Updates and expands Vitest suite with comprehensive space-grouping layout assertions.
@dli7319 dli7319 requested review from qxziuan and ruofeidu June 2, 2026 22:17
Copy link
Copy Markdown
Collaborator

@qxziuan qxziuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dli7319 dli7319 merged commit 04dfe88 into google:main Jun 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants