Skip to content

Commit ed09d09

Browse files
authored
[ci] Remove auto-approvers mechanism (#3473)
gherrit-pr-id: Ghyweelxm6wjg643tibrylyutabstm4eo
1 parent 2f7aef5 commit ed09d09

5 files changed

Lines changed: 1 addition & 483 deletions

File tree

.github/auto-approvers.json

Lines changed: 0 additions & 14 deletions
This file was deleted.

.github/workflows/auto-approve.yml

Lines changed: 0 additions & 272 deletions
This file was deleted.

.github/workflows/ci.yml

Lines changed: 1 addition & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -939,50 +939,6 @@ jobs:
939939
- name: Run todo check
940940
run: ./ci/check_todo.sh
941941

942-
check-auto-approvers:
943-
runs-on: ubuntu-latest
944-
name: Check auto-approvers setup
945-
steps:
946-
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
947-
with:
948-
persist-credentials: false
949-
- name: Structural Check
950-
run: python3 ci/validate_auto_approvers.py --check-config
951-
- name: Health Check (Current Commit)
952-
if: github.event_name == 'pull_request'
953-
env:
954-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
955-
REPOSITORY: ${{ github.repository }}
956-
PR_NUMBER: ${{ github.event.pull_request.number }}
957-
CHANGED_FILES_COUNT: ${{ github.event.pull_request.changed_files }}
958-
run: |
959-
set -eo pipefail
960-
961-
# Fetch changed files (including renames for move-tracking)
962-
gh api "repos/$REPOSITORY/pulls/$PR_NUMBER/files" \
963-
--paginate \
964-
--jq 'map([.filename, .previous_filename] | map(select(.)))' | jq -s 'add' > changed_files.json
965-
966-
# Fetch unique contributors (logins)
967-
CONTRIBUTORS=$(gh api "repos/$REPOSITORY/pulls/$PR_NUMBER/commits" \
968-
--paginate \
969-
--jq '[.[] | .author?.login, .committer?.login] | unique | map(select(.)) | .[]' | tr '\n' ' ')
970-
971-
# Run validator and assert exit code 0 or 1
972-
set +e
973-
python3 ci/validate_auto_approvers.py \
974-
--changed-files changed_files.json \
975-
--expected-count "$CHANGED_FILES_COUNT" \
976-
--contributors $CONTRIBUTORS
977-
EXIT_CODE=$?
978-
set -e
979-
980-
if [ $EXIT_CODE -ne 0 ] && [ $EXIT_CODE -ne 1 ]; then
981-
echo "::error::Validation encountered technical error (exit $EXIT_CODE)"
982-
exit 1
983-
fi
984-
echo "Validation healthy (exit $EXIT_CODE)"
985-
986942
run-git-hooks:
987943
runs-on: ubuntu-latest
988944
name: Run Git hooks
@@ -1085,7 +1041,7 @@ jobs:
10851041
# https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks
10861042
if: failure()
10871043
runs-on: ubuntu-latest
1088-
needs: [build_test, codegen, coverage, kani, check_be_aarch64, check_avr_atmega, check_fmt, check_actions, check_readme, check_versions, check_msrv_is_minimal, check_stale_stderr, check-all-toolchains-tested, check-job-dependencies, check-todo, run-git-hooks, check-auto-approvers, zizmor, build_docker_env]
1044+
needs: [build_test, codegen, coverage, kani, check_be_aarch64, check_avr_atmega, check_fmt, check_actions, check_readme, check_versions, check_msrv_is_minimal, check_stale_stderr, check-all-toolchains-tested, check-job-dependencies, check-todo, run-git-hooks, zizmor, build_docker_env]
10891045
steps:
10901046
- name: Mark the job as failed
10911047
run: exit 1

0 commit comments

Comments
 (0)