Only use layout_for_ptr feature for zerocopy tests#3365
Open
joshlf wants to merge 1 commit into
Open
Conversation
This puts the use of the unstable feature `layout_for_ptr` behind `all(test, miri)`, since it is only necessary for zerocopy tests, not for downstream users. Release 0.8.49. gherrit-pr-id: Gouy5nmgied3joawzp6mdecm3nuhi35jh
joshlf
force-pushed
the
Gouy5nmgied3joawzp6mdecm3nuhi35jh
branch
from
0c57500 to
f590be1
Compare
This was referenced May 13, 2026
Closed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3365 +/- ##
=======================================
Coverage 91.88% 91.88%
=======================================
Files 20 20
Lines 6076 6076
=======================================
Hits 5583 5583
Misses 493 493 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jswrenn
approved these changes
May 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Member
Author
|
@erickt Can you propose a fix for: https://github.com/google/zerocopy/actions/runs/25848263442/job/75948728437#step:14:128 |
|
I can't update this branch, so I pushed up a potential fix for the test failure with #3374. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts the use of the unstable feature
layout_for_ptrbehindall(test, miri), since it is only necessary for zerocopy tests, notfor downstream users.
Release 0.8.49.
layout_for_ptrfeature for zerocopy tests #3365Latest Update: v2 — Compare vs v1
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gouy5nmgied3joawzp6mdecm3nuhi35jh && git checkout -b pr-Gouy5nmgied3joawzp6mdecm3nuhi35jh FETCH_HEADCheckout
git fetch origin refs/heads/Gouy5nmgied3joawzp6mdecm3nuhi35jh && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gouy5nmgied3joawzp6mdecm3nuhi35jh && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.