[anneal][v2] Compile merged util module at stack base#3474
Open
mdittmer wants to merge 1 commit into
Open
Conversation
The v2 stack previously introduced util.rs in a merged PR but declared the module only when the Charon integration started using it. Declare the module as soon as it exists so later PRs can add users without making earlier files look inert. The temporary dead_code allowance is needed because this bottom-of-stack commit only wires in the module; subsequent generate/Charon changes remove the allowance once the utilities have production call sites. gherrit-pr-id: Ga2l5vkuio57w6b4kafskxw2bg4ri57gr
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3474 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 20 20
Lines 6093 6093
=======================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2 stack previously introduced
util.rsin merged PR #3399 but declared the module only when the Charon integration started using it. Declare the module as soon as it exists so later PRs can add users without making earlier files look inert.The temporary
dead_codeallowance is needed because this bottom-of-stack commit only wires in the module; the generate/Charon integration later removes the allowance once the utilities have production call sites.