Add Client parameter to projection traits#3480
Open
jswrenn wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3480 +/- ##
=======================================
Coverage 91.85% 91.86%
=======================================
Files 20 20
Lines 6093 6094 +1
=======================================
+ Hits 5597 5598 +1
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joshlf
approved these changes
Jul 8, 2026
joshlf
left a comment
joshlf
left a comment
Member
There was a problem hiding this comment.
Let's wait to merge until we have a few more PRs on top of this just so we're sure this is the right technical direction?
| /// delegating to an implementation of [`HasField::project`]. | ||
| #[allow(missing_debug_implementations, missing_copy_implementations)] | ||
| pub struct Projection<F: ?Sized, const VARIANT_ID: i128, const FIELD_ID: i128> { | ||
| pub struct Projection<Client, F: ?Sized, const VARIANT_ID: i128, const FIELD_ID: i128> { |
Member
There was a problem hiding this comment.
Comment explaining the purpose of this type param?
This will allow us to emit parallel impls from our various derives without conflict. gherrit-pr-id: Gd2bc8560585e8f472223acf71b96e0f71b2d00c2
jswrenn
force-pushed
the
Gd2bc8560585e8f472223acf71b96e0f71b2d00c2
branch
from
e0b7dc6 to
a574926
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to emit parallel impls from our various derives
without conflict.
Clientparameter to projection traits #3480Latest Update: v2 — Compare vs v1
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gd2bc8560585e8f472223acf71b96e0f71b2d00c2 && git checkout -b pr-Gd2bc8560585e8f472223acf71b96e0f71b2d00c2 FETCH_HEADCheckout
git fetch origin refs/heads/Gd2bc8560585e8f472223acf71b96e0f71b2d00c2 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gd2bc8560585e8f472223acf71b96e0f71b2d00c2 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.