Fix README.md merge

Author: bobhancockg

.gemini/hooks/check_github_version.py

@@ -0,0 +1,98 @@
+import json
+import logging
+import os
+import sys
+import urllib.request
+
+# Setup logging
+# Script is in .gemini/hooks/
+# Log file should be in .gemini/
+base_dir = os.path.dirname(
+    os.path.dirname(os.path.abspath(__file__))
+)  # This is .gemini directory
+log_path = os.path.join(base_dir, "check_github_version.log")
+
+# Create logger
+logger = logging.getLogger()
+logger.setLevel(logging.INFO)
+
+# File handler (keeps full history)
+file_handler = logging.FileHandler(log_path)
+file_handler.setLevel(logging.INFO)
+file_handler.setFormatter(
+    logging.Formatter("%(asctime)s [%(levelname)s] %(message)s")
+)
+logger.addHandler(file_handler)
+
+# Stream handler (only shows warnings and errors to user)
+stream_handler = logging.StreamHandler(sys.stderr)
+stream_handler.setLevel(logging.WARNING)  # Only show WARNING or higher
+stream_handler.setFormatter(
+    logging.Formatter("%(asctime)s [%(levelname)s] %(message)s")
+)
+logger.addHandler(stream_handler)
+
+
+def get_local_version():
+    # gemini-extension.json is in the root directory
+    # So we need to go up one more level from .gemini to find gemini-extension.json
+    root_dir = os.path.dirname(base_dir)
+    json_path = os.path.join(root_dir, "gemini-extension.json")
+
+    try:
+        with open(json_path, "r") as f:
+            data = json.load(f)
+            return data.get("version")
+    except Exception as e:
+        logging.error(f"Error reading local version: {e}")
+        return None
+
+
+def get_remote_version():
+    url = "https://raw.githubusercontent.com/googleads/google-ads-api-developer-assistant/main/gemini-extension.json"
+    try:
+        with urllib.request.urlopen(url, timeout=5) as response:
+            if response.status == 200:
+                data = json.loads(response.read().decode("utf-8"))
+                return data.get("version")
+            else:
+                logging.error(
+                    f"Failed to fetch remote version, status: {response.status}"
+                )
+                return None
+    except Exception as e:
+        logging.error(f"Error fetching remote version: {e}")
+        return None
+
+
+def parse_version(v_str):
+    return tuple(map(int, v_str.split(".")))
+
+
+def main():
+    logging.info("Checking for extension updates...")
+    local_version = get_local_version()
+    remote_version = get_remote_version()
+
+    if not local_version or not remote_version:
+        logging.info("Could not complete version check.")
+        return
+
+    logging.info(
+        f"Local version: {local_version}, Remote version: {remote_version}"
+    )
+
+    try:
+        if parse_version(remote_version) > parse_version(local_version):
+            logging.warning(
+                f"A new version of the extension is available: {remote_version}"
+            )
+            logging.warning("Please run `./update.sh` to update.")
+        else:
+            logging.info("Extension is up to date.")
+    except Exception as e:
+        logging.error(f"Error comparing versions: {e}")
+
+
+if __name__ == "__main__":
+    main()

.gemini/hooks/cleanup_config.py .gemini/hooks/cleanup_environment.py.gemini/hooks/cleanup_config.py renamed to .gemini/hooks/cleanup_environment.py

@@ -11,11 +11,20 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+# ==============================================================================
+# CRITICAL MAINTENANCE NOTE - DO NOT REMOVE
+# ==============================================================================
+# ⚠️ DO NOT migrate lifecycle hooks (SessionStart/SessionEnd) to the extension
+# manifest (hooks/hooks.json or gemini-extension.json).
+#
+# Doing so breaks hook execution in the OSS version of gemini-cli used in this
+# workspace. Hooks MUST remain registered in `.gemini/settings.json` using the
+# `matcher` wrapper list structure to function correctly.
+# ==============================================================================
 
 import os
 import shutil
 import sys
-import datetime
 
 def cleanup():
     # Determine paths
@@ -43,7 +52,16 @@ def cleanup():
             except Exception as e:
                 print(f"Failed to delete {file_path}. Reason: {e}", file=sys.stderr)
 
-        timestamp = datetime.datetime.now()
+        # Delete isolated virtual environment
+        venv_dir = os.path.join(project_root, ".venv")
+        if os.path.exists(venv_dir):
+            print(f"Deleting virtual environment at {venv_dir}...", file=sys.stderr)
+            try:
+                shutil.rmtree(venv_dir)
+                print("Virtual environment deleted successfully.", file=sys.stderr)
+            except Exception as e:
+                print(f"Failed to delete virtual environment: {e}", file=sys.stderr)
+
 
     except Exception as e:
         print(f"Error cleaning up config directory: {e}", file=sys.stderr)